Skip to content

Multi-tenancy quota enforcement (max_creators/max_tips_per_day) — confirm it's actually enforced anywhere, given the underlying schema doesn't currently have those columns #393

Description

@Christopherdominic

Following directly from the tenants migration-collision issue elsewhere in this audit: even once the schema question is resolved and max_creators/max_tips_per_day genuinely exist as columns, it's worth separately confirming whether any code path actually reads and enforces those quotas (e.g. rejecting creator registration once a tenant's max_creators is reached, or throttling tip recording once max_tips_per_day is hit) — as opposed to the columns existing purely as unenforced metadata. Given the columns don't even exist in the live schema today, it seems unlikely any enforcement code currently runs successfully.

Task: Grep for any read of max_creators/max_tips_per_day outside of the migration files and TenantProvisioner's (currently broken) insert. If no enforcement exists, this is effectively an entire unimplemented feature masquerading as done (schema + provisioning API present, actual business rule absent) — implement the enforcement checks, or clearly document that quotas are metadata-only for now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third CampaignarchitectureStructural or architectural changebugSomething isn't workingdifficulty: very hardRequires deep expertise and substantial effort

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions