Skip to content

Inconsistent editor color in definition list #2893

Open
@pinkdroyd

Description

@pinkdroyd

Issuehunt badges

Current behavior

When I create an definition list that consists of a bullet list, the editor highlights in inconsistently. The first line is highlighted just like text, the next lines like a bullet list. This creates a bit of a chaotic page if you use these lists a lot.

This is what it looks like in the preview (this is fine, just so you know what I am talking about):
grafik

This is what it looks like in the editor (all items should be blue, however the first one of each definition is white):
grafik

Expected behavior

The first line of the bullet list in a definition should look like the other lines (in my case blue, not white). Like this (this is the coloring of a list):
grafik

Environment

  • Version: 0.11.13

There is a $22.00 open bounty on this issue. Add more on Issuehunt.

Activity

IssueHuntBot

IssueHuntBot commented on Feb 28, 2019

@IssueHuntBot

@BoostIO has funded $20.00 to this issue. See it on IssueHunt

ekoeditaa

ekoeditaa commented on Mar 12, 2019

@ekoeditaa

Can I take this up? Thanks!

ekoeditaa

ekoeditaa commented on Mar 13, 2019

@ekoeditaa

Does CodeMirror take care of the highlighting? Or is it done by our own repo?
I tracked down the highlighting up till here browser/components/CodeEditor.js

ZeroX-DG

ZeroX-DG commented on Mar 13, 2019

@ZeroX-DG
Member

@ekoeditaa yes, CodeMirror take care of the highlighting so this probably an upstream issue. However, Boostnote also has a custom mode here https://github.com/BoostIO/Boostnote/tree/master/extra_scripts/codemirror/mode/bfm

ekoeditaa

ekoeditaa commented on Mar 14, 2019

@ekoeditaa

@ZeroX-DG Seems like the first bullet list is missing cm-variable-2 class. How can I add it dynamically? Can it be done from the bfm grunt task too?

ZeroX-DG

ZeroX-DG commented on Mar 18, 2019

@ZeroX-DG
Member

@ekoeditaa Yes, you should do it in the bfm grunt task because the style file will be overridden when the task is executed

ekoeditaa

ekoeditaa commented on Mar 23, 2019

@ekoeditaa

@ZeroX-DG seems like it cannot be done through that. The problem is upstream with CodeMirror. The highlighting doesn't work for indentation from them. We cannot solve it by overriding the css in our custom mode. A possible fix is we let cm-variable-2 color to be the normal black.

added
funded on issuehunt 💵Issue has received funding that will be rewarded to the contributor solving this issue.
on May 14, 2019
IssueHuntBot

IssueHuntBot commented on May 14, 2019

@IssueHuntBot

@0maxxam0 has funded $2.00 to this issue.


removed
funded on issuehunt 💵Issue has received funding that will be rewarded to the contributor solving this issue.
on May 14, 2019
added
funded on issuehunt 💵Issue has received funding that will be rewarded to the contributor solving this issue.
and removed on Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐛Issue concerns a bug.funded on issuehunt 💵Issue has received funding that will be rewarded to the contributor solving this issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @Flexo013@pinkdroyd@kazup01@ekoeditaa@ZeroX-DG

      Issue actions

        Inconsistent editor color in definition list · Issue #2893 · BoostIO/BoostNote-Legacy