Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Commit 201b59c

Browse files
committed
Update export progress and all export mode
Fix all export mode
1 parent 89f01b5 commit 201b59c

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/components/molecules/Export/ExportProgressItem.tsx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,8 @@ const ExportProgressItem = ({
262262
)
263263
const exportAsMd = async (noteDoc: NoteDoc, exportPath: string) => {
264264
const mdString = convertNoteDocToMarkdownString(noteDoc, includeFrontMatter)
265-
await writeFile(exportPath, mdString)
265+
const filename = `${exportPath}.md`
266+
await writeFile(filename, mdString)
266267
}
267268

268269
const exportAsPdf = async (
@@ -279,7 +280,8 @@ const ExportProgressItem = ({
279280
preferences['export.printOptions'],
280281
previewStyle
281282
)
282-
await writeFile(exportPath, pdfBuffer)
283+
const filename = `${exportPath}.pdf`
284+
await writeFile(filename, pdfBuffer)
283285
}
284286

285287
const exportAsHtml = async (
@@ -320,10 +322,11 @@ const ExportProgressItem = ({
320322
const exportNoteFilenameWithoutExtension = `${filenamify(
321323
getValidNoteTitle(noteDoc)
322324
)}`
323-
const exportNotePathname = join(
325+
const exportNotePathnameNoExt = join(
324326
join(rootDir, noteExportFolder),
325-
`${exportNoteFilenameWithoutExtension}.${exportProcedureData.exportType}`
327+
exportNoteFilenameWithoutExtension
326328
)
329+
const exportNotePathname = `${exportNotePathnameNoExt}.${exportProcedureData.exportType}`
327330
setExportState({
328331
exportProgressValue: convertValueToPercentage(
329332
exportingNoteIndex / notesToExport.length
@@ -353,7 +356,7 @@ const ExportProgressItem = ({
353356
break
354357
case 'md':
355358
try {
356-
await exportAsMd(noteDoc as NoteDoc, exportNotePathname)
359+
await exportAsMd(noteDoc as NoteDoc, exportNotePathnameNoExt)
357360
} catch (err) {
358361
addExportError(
359362
`Cannot export: '${exportNotePathname.substring(
@@ -364,7 +367,7 @@ const ExportProgressItem = ({
364367
break
365368
case 'all':
366369
try {
367-
await exportAsMd(noteDoc as NoteDoc, exportNotePathname)
370+
await exportAsMd(noteDoc as NoteDoc, exportNotePathnameNoExt)
368371
} catch (err) {
369372
addExportError(
370373
`Cannot export: '${exportNotePathname.substring(
@@ -387,7 +390,7 @@ const ExportProgressItem = ({
387390
try {
388391
await exportAsPdf(
389392
noteDoc as NoteDoc,
390-
exportNotePathname,
393+
exportNotePathnameNoExt,
391394
attachmentMap
392395
)
393396
} catch (err) {
@@ -403,7 +406,7 @@ const ExportProgressItem = ({
403406
try {
404407
await exportAsPdf(
405408
noteDoc as NoteDoc,
406-
exportNotePathname,
409+
exportNotePathnameNoExt,
407410
attachmentMap
408411
)
409412
} catch (err) {

src/components/pages/WikiNotePage.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useCallback, useEffect, useMemo } from 'react'
1+
import React, { useCallback, useMemo } from 'react'
22
import { NoteStorage } from '../../lib/db/types'
33
import NoteDetail from '../organisms/NoteDetail'
44
import {
@@ -17,11 +17,7 @@ import { usePreferences } from '../../lib/preferences'
1717
import { usePreviewStyle } from '../../lib/preview'
1818
import { mapTopBarTree } from '../../lib/v2/mappers/local/topbarTree'
1919
import { useLocalUI } from '../../lib/v2/hooks/useLocalUI'
20-
import {
21-
getPathByName,
22-
showSaveDialog,
23-
openPath,
24-
} from '../../lib/electronOnly'
20+
import { getPathByName, showSaveDialog, openPath } from '../../lib/electronOnly'
2521
import { useIpcListener } from '../../lib/useIpcListener'
2622
import path from 'path'
2723
import pathParse from 'path-parse'
@@ -203,6 +199,7 @@ const WikiNotePage = ({ storage }: WikiNotePageProps) => {
203199

204200
const includeFrontMatter = preferences['markdown.includeFrontMatter']
205201

202+
// todo: sometimes seems to open multiple windows when cancelled by user
206203
useIpcListener('save-as', async () => {
207204
if (note == null) {
208205
return

0 commit comments

Comments
 (0)