Commit 0f278dc
Stabilize metrics integration tests
Removes DropwizardMetricsIT, MicroProfileMetricsIT, MicrometerMetricsIT
from parallelizable tests category, making them serial.
Additionally enables MicrometerMetricsIT which was previously ignored
due to flakiness.
`should_evict_down_node_metrics_when_timeout_fires` in MetricsITBase
relies on setting static field `MIN_EXPIRE_AFTER` in AbstractMetricUpdater
and then setting it back to 5 minutes.
Those three test classes inherit this test method and when they run
concurrently it sometimes results in setting the minimal expire time back
to 5 minutes before another test initializes its session with expire time
set to 1 second. This can be evidenced by the appearance of lines like
```
c.d.o.d.i.c.m.AbstractMetricUpdater - [s6] Value too low for advanced.metrics.node.expire-after: PT1S. Forcing to PT5M instead.
```
whenever that method fails. It does not appear when the test passes (due to
lucky schedule).
Making those tests serial seems to be the simplest solution.1 parent b681949 commit 0f278dc
File tree
3 files changed
+6
-11
lines changed- integration-tests/src/test/java/com/datastax/oss/driver
- core/metrics
- metrics
- micrometer
- microprofile
3 files changed
+6
-11
lines changedLines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | 42 | | |
45 | | - | |
| 43 | + | |
| 44 | + | |
46 | 45 | | |
47 | 46 | | |
48 | 47 | | |
| |||
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | | - | |
45 | 42 | | |
46 | | - | |
47 | | - | |
| 43 | + | |
| 44 | + | |
48 | 45 | | |
49 | 46 | | |
50 | 47 | | |
| |||
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
47 | | - | |
48 | 46 | | |
49 | | - | |
| 47 | + | |
| 48 | + | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
| |||
0 commit comments