Skip to content

Commit 58e5681

Browse files
authored
fix ts build (#2435)
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds `push` trigger for `ts-release` branch and updates build environment for `aarch64-unknown-linux-gnu` in `build-typescript-release.reusable.yaml`. > > - **Workflow Trigger**: > - Adds `push` trigger for `ts-release` branch in `build-typescript-release.reusable.yaml`. > - **Build Environment**: > - Changes host for `aarch64-unknown-linux-gnu` target to `ubuntu-22.04-arm`. > - Comments out container for `aarch64-unknown-linux-gnu` due to issue with `ring` library. > - Adds notes for potential fixes and future container approach. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup> for 0671990. You can [customize](https://app.ellipsis.dev/BoundaryML/settings/summaries) this summary. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
1 parent a227e3d commit 58e5681

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

.github/workflows/build-typescript-release.reusable.yaml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ name: BAML Release - Build Typescript
22

33
on:
44
workflow_call: {}
5+
push:
6+
branches:
7+
- ts-release
58

69
concurrency:
710
# suffix is important to prevent a concurrency deadlock with the calling workflow
@@ -28,11 +31,15 @@ jobs:
2831

2932
- target: aarch64-unknown-linux-gnu
3033
# Do not use -latest, since it uses a different glibc version!
31-
host: ubuntu-22.04
34+
host: ubuntu-22.04-arm
3235
# from https://github.com/PyO3/maturin-action?tab=readme-ov-file#manylinux-docker-container
3336
# need a new version of manylinux to build crates on arm64-linux
34-
container: ghcr.io/rust-cross/manylinux_2_28-cross:aarch64
35-
node_build: pnpm build:napi-release --target aarch64-unknown-linux-gnu --use-napi-cross
37+
# Note: update (aaron): this container doesnt work due to this error with ring:
38+
# https://github.com/briansmith/ring/issues/1728
39+
# So now we use ubuntu-arm, but glibc is too high, so we have to figure out container approach later.
40+
# potential fix in https://github.com/apache/opendal/issues/5483
41+
# container: ghcr.io/rust-cross/manylinux_2_28-cross:aarch64
42+
node_build: pnpm build:napi-release --target aarch64-unknown-linux-gnu
3643
cargo_args: -p baml-typescript-ffi -p baml-python-ffi
3744

3845
- target: x86_64-apple-darwin

0 commit comments

Comments
 (0)