chore: fix linting and add golangci-lint CI workflow

- Fixes the following lint findings:
  - Replace nil contexts in git_test.go with context.Background()
  - Rename unused interface-satisfying parameters to _ in cobra
    callbacks (root.go, clean.go) and test fakes (git_test.go,
    workspace_test.go)

Author: BradyPlanden

.github/workflows/lint.yml

@@ -0,0 +1,27 @@
+name: Lint
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  lint:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+          cache: false
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: latest

.golangci.yml

@@ -0,0 +1,23 @@
+version: "2"
+
+run:
+  timeout: 5m
+
+linters:
+  default: standard
+  enable:
+    - misspell
+    - revive
+  settings:
+    errcheck:
+      # Ignore unhandled errors from fmt output functions — writing to a
+      # CLI's stdout/stderr is conventional to ignore since there is no
+      # useful recovery action when terminal output fails.
+      exclude-functions:
+        - fmt.Fprint
+        - fmt.Fprintf
+        - fmt.Fprintln
+
+formatters:
+  enable:
+    - goimports

README.md

@@ -2,7 +2,7 @@
     <img src="./assets/prt-logo.png" alt="prt-logo" width="150" />
 </p>
 
-## The 'pitch'
+## The problem
 
 Reviewing a PR can require the following repetitive setup:
 

internal/cli/clean.go

@@ -24,7 +24,7 @@ func newCleanCommand(rootOpts *rootOptions) *cobra.Command {
 		Example: "" +
 			"  prt clean --dry-run\n" +
 			"  prt clean --all",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			return runClean(cmd, rootOpts, opts)
 		},
 	}

internal/cli/root.go

@@ -39,7 +39,7 @@ func newRootCommand(version string) *cobra.Command {
 			"  prt https://github.com/OWNER/REPO/pull/123 --temp\n" +
 			"  prt https://github.com/OWNER/REPO/pull/123 --no-tab\n" +
 			"  prt clean --dry-run",
-		Args: func(cmd *cobra.Command, args []string) error {
+		Args: func(_ *cobra.Command, args []string) error {
 			if len(args) == 0 {
 				return fmt.Errorf("missing PR URL argument (run 'prt --help')")
 			}
@@ -84,7 +84,7 @@ func newVersionCommand(version string) *cobra.Command {
 		Use:   "version",
 		Short: "Print prt version",
 		Args:  cobra.NoArgs,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(cmd *cobra.Command, _ []string) {
 			fmt.Fprintf(cmd.OutOrStdout(), "prt version %s\n", version)
 		},
 	}

internal/git/git_test.go

@@ -53,24 +53,25 @@ func TestHasRemote(t *testing.T) {
 		output: "origin\nfork\nprt-fork\n",
 	}
 	client := &Client{runner: fakeRunner}
+	ctx := context.Background()
 
-	has, err := client.HasRemote(nil, "/repo", "origin")
+	has, err := client.HasRemote(ctx, "/repo", "origin")
 	if err != nil {
 		t.Fatalf("HasRemote: %v", err)
 	}
 	if !has {
 		t.Fatalf("expected HasRemote to return true for origin")
 	}
 
-	has, err = client.HasRemote(nil, "/repo", "prt-fork")
+	has, err = client.HasRemote(ctx, "/repo", "prt-fork")
 	if err != nil {
 		t.Fatalf("HasRemote: %v", err)
 	}
 	if !has {
 		t.Fatalf("expected HasRemote to return true for prt-fork")
 	}
 
-	has, err = client.HasRemote(nil, "/repo", "nonexistent")
+	has, err = client.HasRemote(ctx, "/repo", "nonexistent")
 	if err != nil {
 		t.Fatalf("HasRemote: %v", err)
 	}
@@ -85,7 +86,7 @@ func TestRemoteURL(t *testing.T) {
 	}
 	client := &Client{runner: fakeRunner}
 
-	url, err := client.RemoteURL(nil, "/repo", "origin")
+	url, err := client.RemoteURL(context.Background(), "/repo", "origin")
 	if err != nil {
 		t.Fatalf("RemoteURL: %v", err)
 	}
@@ -131,6 +132,6 @@ type fakeRunner struct {
 	err    error
 }
 
-func (r *fakeRunner) Run(ctx context.Context, dir string, name string, args ...string) (string, error) {
+func (r *fakeRunner) Run(_ context.Context, _ string, _ string, _ ...string) (string, error) {
 	return r.output, r.err
 }

internal/workspace/workspace_test.go

@@ -87,12 +87,12 @@ func newFakeGit() *fakeGit {
 	}
 }
 
-func (f *fakeGit) IsGitRepo(ctx context.Context, repoDir string) (bool, error) {
+func (f *fakeGit) IsGitRepo(_ context.Context, repoDir string) (bool, error) {
 	_, ok := f.repos[repoDir]
 	return ok, nil
 }
 
-func (f *fakeGit) Clone(ctx context.Context, url string, dest string) error {
+func (f *fakeGit) Clone(_ context.Context, url string, dest string) error {
 	if err := os.MkdirAll(dest, 0o755); err != nil {
 		return err
 	}
@@ -104,26 +104,26 @@ func (f *fakeGit) Clone(ctx context.Context, url string, dest string) error {
 	return nil
 }
 
-func (f *fakeGit) CloneBare(ctx context.Context, url string, dest string, depth int) error {
+func (f *fakeGit) CloneBare(ctx context.Context, url string, dest string, _ int) error {
 	return f.Clone(ctx, url, dest)
 }
 
-func (f *fakeGit) Fetch(ctx context.Context, repoDir string, remote string, refspec string) error {
+func (f *fakeGit) Fetch(_ context.Context, repoDir string, remote string, refspec string) error {
 	f.fetches = append(f.fetches, fetchCall{repoDir: repoDir, remote: remote, refspec: refspec})
 	return f.fetchErr
 }
 
-func (f *fakeGit) FetchBranch(ctx context.Context, repoDir string, remote string, branch string) error {
+func (f *fakeGit) FetchBranch(_ context.Context, repoDir string, remote string, branch string) error {
 	f.branchFetches = append(f.branchFetches, branchFetchCall{repoDir: repoDir, remote: remote, branch: branch})
 	return f.fetchBranchErr
 }
 
-func (f *fakeGit) SubmoduleUpdate(ctx context.Context, repoDir string) error {
+func (f *fakeGit) SubmoduleUpdate(_ context.Context, repoDir string) error {
 	f.submoduleUpdates = append(f.submoduleUpdates, repoDir)
 	return f.submoduleUpdateErr
 }
 
-func (f *fakeGit) WorktreeAdd(ctx context.Context, repoDir string, worktreePath string, branch string) error {
+func (f *fakeGit) WorktreeAdd(_ context.Context, repoDir string, worktreePath string, branch string) error {
 	if err := os.MkdirAll(worktreePath, 0o755); err != nil {
 		return err
 	}
@@ -132,7 +132,7 @@ func (f *fakeGit) WorktreeAdd(ctx context.Context, repoDir string, worktreePath
 	return nil
 }
 
-func (f *fakeGit) WorktreeRemove(ctx context.Context, repoDir string, worktreePath string, force bool) error {
+func (f *fakeGit) WorktreeRemove(_ context.Context, repoDir string, worktreePath string, _ bool) error {
 	if err := os.RemoveAll(worktreePath); err != nil {
 		return err
 	}
@@ -145,7 +145,7 @@ func (f *fakeGit) WorktreeRemove(ctx context.Context, repoDir string, worktreePa
 	return nil
 }
 
-func (f *fakeGit) WorktreeList(ctx context.Context, repoDir string) ([]git.Worktree, error) {
+func (f *fakeGit) WorktreeList(_ context.Context, repoDir string) ([]git.Worktree, error) {
 	repo, ok := f.repos[repoDir]
 	if !ok {
 		return nil, nil
@@ -157,7 +157,7 @@ func (f *fakeGit) WorktreeList(ctx context.Context, repoDir string) ([]git.Workt
 	return worktrees, nil
 }
 
-func (f *fakeGit) HasWorktreeForBranch(ctx context.Context, repoDir string, branch string) (string, bool, error) {
+func (f *fakeGit) HasWorktreeForBranch(_ context.Context, repoDir string, branch string) (string, bool, error) {
 	if repo, ok := f.repos[repoDir]; ok {
 		if path, ok := repo.worktrees[branch]; ok {
 			return path, true, nil
@@ -166,15 +166,15 @@ func (f *fakeGit) HasWorktreeForBranch(ctx context.Context, repoDir string, bran
 	return "", false, nil
 }
 
-func (f *fakeGit) OriginURL(ctx context.Context, repoDir string) (string, error) {
+func (f *fakeGit) OriginURL(_ context.Context, repoDir string) (string, error) {
 	repo, ok := f.repos[repoDir]
 	if !ok {
 		return "", nil
 	}
 	return repo.origin, nil
 }
 
-func (f *fakeGit) AddRemote(ctx context.Context, repoDir string, name string, url string) error {
+func (f *fakeGit) AddRemote(_ context.Context, repoDir string, name string, url string) error {
 	repo, ok := f.repos[repoDir]
 	if !ok {
 		return nil
@@ -186,7 +186,7 @@ func (f *fakeGit) AddRemote(ctx context.Context, repoDir string, name string, ur
 	return nil
 }
 
-func (f *fakeGit) HasRemote(ctx context.Context, repoDir string, name string) (bool, error) {
+func (f *fakeGit) HasRemote(_ context.Context, repoDir string, name string) (bool, error) {
 	repo, ok := f.repos[repoDir]
 	if !ok {
 		return false, nil
@@ -195,22 +195,22 @@ func (f *fakeGit) HasRemote(ctx context.Context, repoDir string, name string) (b
 	return exists, nil
 }
 
-func (f *fakeGit) SetUpstream(ctx context.Context, repoDir string, branch string, upstream string) error {
+func (f *fakeGit) SetUpstream(_ context.Context, repoDir string, branch string, upstream string) error {
 	f.upstreams = append(f.upstreams, upstreamCall{repoDir: repoDir, branch: branch, upstream: upstream})
 	return nil
 }
 
-func (f *fakeGit) ConfigSet(ctx context.Context, repoDir string, key string, value string) error {
+func (f *fakeGit) ConfigSet(_ context.Context, repoDir string, key string, value string) error {
 	f.configs = append(f.configs, configCall{repoDir: repoDir, key: key, value: value})
 	return nil
 }
 
-func (f *fakeGit) ConfigSetWorktree(ctx context.Context, repoDir string, key string, value string) error {
+func (f *fakeGit) ConfigSetWorktree(_ context.Context, repoDir string, key string, value string) error {
 	f.configs = append(f.configs, configCall{repoDir: repoDir, key: "--worktree:" + key, value: value})
 	return nil
 }
 
-func (f *fakeGit) WorktreeAddBranch(ctx context.Context, repoDir string, worktreePath string, branch string, startPoint string, force bool) error {
+func (f *fakeGit) WorktreeAddBranch(_ context.Context, repoDir string, worktreePath string, branch string, startPoint string, _ bool) error {
 	if f.branchAddFirstCallErr != nil && f.branchAddCallCount == 0 {
 		f.branchAddCallCount++
 		return f.branchAddFirstCallErr