Skip to content

Commit fc3eb6f

Browse files
[SDK-2449] Bumped SDK versions and updated logging code (#33)
* Bumped version and updated logging code * Changed to 4.0.0
1 parent dac62da commit fc3eb6f

File tree

5 files changed

+19
-14
lines changed

5 files changed

+19
-14
lines changed

AdobeBranchExtension.podspec

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "AdobeBranchExtension"
3-
s.version = "3.1.0"
3+
s.version = "4.0.0"
44
s.summary = "The Branch extension for Adobe Cloud Platform on iOS."
55

66
s.description = <<-DESC
@@ -22,9 +22,9 @@ Pod::Spec.new do |s|
2222

2323
s.source_files = 'AdobeBranchExtension/Classes/**/*'
2424

25-
s.dependency 'AEPCore', '~> 4.2.0'
26-
s.dependency 'AEPLifecycle', '~> 4.2.0'
27-
s.dependency 'AEPIdentity', '~> 4.2.0'
28-
s.dependency 'AEPSignal', '~> 4.2.0'
29-
s.dependency 'BranchSDK', '~> 3.2.0'
25+
s.dependency 'AEPCore', '~> 5.1.0'
26+
s.dependency 'AEPLifecycle', '~> 5.1.0'
27+
s.dependency 'AEPIdentity', '~> 5.1.0'
28+
s.dependency 'AEPSignal', '~> 5.1.0'
29+
s.dependency 'BranchSDK', '~> 3.4.4'
3030
end

AdobeBranchExtension/Classes/AdobeBranchExtensionClass.m

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ - (nullable instancetype)initWithRuntime:(id<AEPExtensionRuntime> _Nonnull)runti
7070
}
7171

7272
- (void)onRegistered {
73-
[[BranchLogger shared] logDebug:@"AdobeBranchExtension listener registered"];
73+
[[BranchLogger shared] logDebug:@"AdobeBranchExtension listener registered" error:nil];
7474

7575
[self deviceDataSharedState: NULL];
7676

@@ -138,7 +138,7 @@ + (BOOL)configureEventExclusionList:(nullable NSArray<NSString *> *)eventNames e
138138
// If already configured allowList
139139
if ([AdobeBranchExtensionConfig instance].allowList.count != 0) {
140140
*configError = [NSError errorWithDomain:AdobeBranchExtensionErrorDomain code:ABEBranchConflictConfiguration userInfo:@{NSLocalizedFailureReasonErrorKey: @"Already configured allowList for AdobeBranchExtensionConfig"}];
141-
[[BranchLogger shared] logWarning:[NSString stringWithFormat:@"AdobeBranchExtensionConfig error: %@.", *configError]];
141+
[[BranchLogger shared] logWarning:[NSString stringWithFormat:@"AdobeBranchExtensionConfig error: %@.", *configError] error:*configError];
142142
return NO;
143143
} else {
144144
[AdobeBranchExtensionConfig instance].exclusionList = eventNames;
@@ -152,7 +152,7 @@ + (BOOL)configureEventAllowList:(nullable NSArray<NSString *> *)eventNames error
152152
// If already configured allowList
153153
if ([AdobeBranchExtensionConfig instance].exclusionList.count != 0) {
154154
*configError = [NSError errorWithDomain:AdobeBranchExtensionErrorDomain code:ABEBranchConflictConfiguration userInfo:@{NSLocalizedFailureReasonErrorKey: @"Already configured exclusionList for AdobeBranchExtensionConfig"}];
155-
[[BranchLogger shared] logWarning:[NSString stringWithFormat:@"AdobeBranchExtensionConfig error: %@.", *configError]];
155+
[[BranchLogger shared] logWarning:[NSString stringWithFormat:@"AdobeBranchExtensionConfig error: %@.", *configError] error:*configError];
156156
return NO;
157157
} else {
158158
[AdobeBranchExtensionConfig instance].allowList = eventNames;
@@ -164,7 +164,7 @@ + (BOOL)configureEventAllowList:(nullable NSArray<NSString *> *)eventNames error
164164
#pragma mark - Action Events
165165

166166
- (void)handleEvent:(AEPEvent*)event {
167-
[[BranchLogger shared] logDebug:[NSString stringWithFormat:@"Handling Event: %@", event]];
167+
[[BranchLogger shared] logDebug:[NSString stringWithFormat:@"Handling Event: %@", event] error:nil];
168168

169169
if ([[AdobeBranchExtensionConfig instance].eventTypes containsObject:event.type] &&
170170
[[AdobeBranchExtensionConfig instance].eventSources containsObject:event.source]) {
@@ -333,11 +333,11 @@ - (void) passAdobeIdsToBranch:(AEPEvent*)eventToProcess {
333333
AEPSharedStateResult *configSharedState = [self.runtime getSharedStateWithExtensionName:eventToProcess.data[ABEAdobeEventDataKey_StateOwner] event:eventToProcess barrier:NO];
334334

335335
if (!configSharedState.value) {
336-
[[BranchLogger shared] logWarning: @"BranchSDK_ Could not process event, configuration shared state is pending"];
336+
[[BranchLogger shared] logWarning: @"BranchSDK_ Could not process event, configuration shared state is pending" error:nil];
337337
return;
338338
}
339339
if (error) {
340-
[[BranchLogger shared] logWarning: @"BranchSDK_ Could not process event, an error occured while retrieving configuration shared state"];
340+
[[BranchLogger shared] logWarning: @"BranchSDK_ Could not process event, an error occured while retrieving configuration shared state" error:nil];
341341
return;
342342
}
343343

Examples/AdobeBranchExample/AdobeBranchExample.xcodeproj/project.pbxproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 51;
6+
objectVersion = 54;
77
objects = {
88

99
/* Begin PBXBuildFile section */
@@ -25,6 +25,7 @@
2525
ACAE81332122645B0049505B /* UserNotifications.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = ACAE81322122645B0049505B /* UserNotifications.framework */; };
2626
ACAE8135212264610049505B /* SystemConfiguration.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = ACAE8134212264610049505B /* SystemConfiguration.framework */; };
2727
C10F392A278E39AD00BF5D36 /* AdSupport.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = C10F3929278E39AD00BF5D36 /* AdSupport.framework */; };
28+
C12534432C18F6E4008A83C4 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = C12534422C18EE39008A83C4 /* PrivacyInfo.xcprivacy */; };
2829
/* End PBXBuildFile section */
2930

3031
/* Begin PBXFileReference section */
@@ -63,6 +64,7 @@
6364
ACF671D921534E4F00CDC900 /* ACPLifecycle_iOS.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ACPLifecycle_iOS.framework; path = Pods/ACPCoreBeta/ACPLifecycle_iOS.framework; sourceTree = "<group>"; };
6465
B0EA9C30991048D8A522C726 /* Pods_AdobeBranchExample.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_AdobeBranchExample.framework; sourceTree = BUILT_PRODUCTS_DIR; };
6566
C10F3929278E39AD00BF5D36 /* AdSupport.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AdSupport.framework; path = System/Library/Frameworks/AdSupport.framework; sourceTree = SDKROOT; };
67+
C12534422C18EE39008A83C4 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
6668
F8688AE753553EE80251EE11 /* Pods-adobe-branch-example.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-adobe-branch-example.release.xcconfig"; path = "Pods/Target Support Files/Pods-adobe-branch-example/Pods-adobe-branch-example.release.xcconfig"; sourceTree = "<group>"; };
6769
FD81B1B19DDC0E314016948F /* Pods-adobe-branch-example.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-adobe-branch-example.debug.xcconfig"; path = "Pods/Target Support Files/Pods-adobe-branch-example/Pods-adobe-branch-example.debug.xcconfig"; sourceTree = "<group>"; };
6870
/* End PBXFileReference section */
@@ -118,6 +120,7 @@
118120
ACAE8106212263F30049505B /* AdobeBranchExample */ = {
119121
isa = PBXGroup;
120122
children = (
123+
C12534422C18EE39008A83C4 /* PrivacyInfo.xcprivacy */,
121124
ACF671CD2150B42800CDC900 /* AdobeBranchExample.entitlements */,
122125
ACAE8107212263F30049505B /* AppDelegate.h */,
123126
ACAE8108212263F30049505B /* AppDelegate.m */,
@@ -229,6 +232,7 @@
229232
ACAE8111212263F40049505B /* Assets.xcassets in Resources */,
230233
4DE097FD219CEABE008AC401 /* Products.json in Resources */,
231234
4D16DBA421AF037F00E362A2 /* Launch Screen.storyboard in Resources */,
235+
C12534432C18F6E4008A83C4 /* PrivacyInfo.xcprivacy in Resources */,
232236
ACAE810F212263F40049505B /* Main.storyboard in Resources */,
233237
);
234238
runOnlyForDeploymentPostprocessing = 0;

Examples/AdobeBranchExample/AdobeBranchExample/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
3030
// initialize Branch session, [AdobeBranchExtension initSessionWithLaunchOptions] is different from
3131
// [[Branch getInstance] initSessionWithLaunchOptions] in that it holds up initialization in order to collect
3232
// Adobe IDs and pass them to Branch as request metadata, see [AdobeBranchExtension delayInitSessionToCollectAdobeIDs]
33-
[[Branch getInstance] enableLogging];
33+
[Branch enableLogging];
3434
[AdobeBranchExtension initSessionWithLaunchOptions:launchOptions andRegisterDeepLinkHandler:^(NSDictionary * _Nullable params, NSError * _Nullable error) {
3535
if (!error && params && [params[@"+clicked_branch_link"] boolValue]) {
3636

Examples/AdobeBranchExample/AdobeBranchExample/ProductListViewController.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath
109109
[linkProperties addControlParam:@"$desktop_url" withValue: @"https://branch.io/branch/Glasses.html"];
110110

111111
[branchUniversalObject getShortUrlWithLinkProperties:linkProperties andCallback:^(NSString *url, NSError *error) {
112+
NSLog(@"Created Short Link: %@", url);
112113
[self showCreatedLink:url];
113114
}];
114115
break;

0 commit comments

Comments
 (0)