-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
Running the gradle plugin: canISayByeByeJetifier to determine if it is safe to turn off the Jetifier in our codebase (to optimise build time).
It throws up branch as problematic, due to the following references
Graphs to this dependency:
+---io.branch.sdk.android:library:5.0.7
Issues found:
* io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsClient
* io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsCallback
* io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsSession
Via the following code
{
try {
CustomTabsClientClass = Class.forName("android.support.customtabs.CustomTabsClient");
CustomTabsCallbackClass = Class.forName("android.support.customtabs.CustomTabsCallback");
CustomTabsSessionClass = Class.forName("android.support.customtabs.CustomTabsSession");
ICustomTabsServiceClass = Class.forName("android.support.customtabs.ICustomTabsService");
} catch (Exception t) {
isCustomTabsAvailable_ = false;
}
}
On the face of it then, I'm not sure if things will work correctly without Jetifier (as there is no androidx lookup above) - can you confirm ?
Metadata
Metadata
Assignees
Labels
No labels