refactor: remove processNextQueueItem method and related calls for automatic queue processing

- Eliminate the processNextQueueItem method from BranchRequestQueueAdapter and ServerRequestQueue
- Update Branch class to reflect automatic processing of queue items after unlocking wait locks
- Simplify code by removing manual triggers for queue processing, enhancing SDK efficiency and clarity
- This change is part of the ongoing modernization efforts to streamline the Branch SDK

Author: wpinho-branch

Branch-SDK/src/androidTest/java/io/branch/referral/BranchRequestQueueTest.kt

@@ -65,7 +65,7 @@ class BranchRequestQueueTest : BranchTest() {
 
         // Test that compatibility methods don't crash
         adapter.printQueue()
-        adapter.processNextQueueItem("test")
+        // processNextQueueItem method removed - no longer needed for compatibility
         adapter.unlockProcessWait(ServerRequest.PROCESS_WAIT_LOCK.SDK_INIT_WAIT_LOCK)
         adapter.postInitClear()
 

Branch-SDK/src/main/java/io/branch/referral/Branch.java

@@ -836,7 +836,8 @@ void unlockSDKInitWaitLock() {
         if (requestQueue_ == null) return;
         requestQueue_.postInitClear();
         requestQueue_.unlockProcessWait(ServerRequest.PROCESS_WAIT_LOCK.SDK_INIT_WAIT_LOCK);
-        requestQueue_.processNextQueueItem("unlockSDKInitWaitLock");
+        // processNextQueueItem call removed - critical SDK initialization unlock handled automatically
+        // Modern queue processes immediately when SDK_INIT_WAIT_LOCK is released via unlockProcessWait
     }
 
     private boolean isIntentParamsAlreadyConsumed(Activity activity) {
@@ -1306,7 +1307,8 @@ void registerAppInit(@NonNull ServerRequestInitSession request, boolean forceBra
          requestQueue_.printQueue();
          initTasks(request);
 
-         requestQueue_.processNextQueueItem("registerAppInit");
+         // processNextQueueItem call removed - app initialization processing handled automatically
+         // Modern queue processes init session request immediately after initTasks completes
      }
 
     private void initTasks(ServerRequest request) {
@@ -1327,7 +1329,7 @@ private void initTasks(ServerRequest request) {
                 public void onInstallReferrersFinished() {
                     request.removeProcessWaitLock(ServerRequest.PROCESS_WAIT_LOCK.INSTALL_REFERRER_FETCH_WAIT_LOCK);
                     BranchLogger.v("INSTALL_REFERRER_FETCH_WAIT_LOCK removed");
-                    requestQueue_.processNextQueueItem("onInstallReferrersFinished");
+                    // processNextQueueItem call removed - modern queue processes automatically via unlockProcessWait
                 }
             });
         }
@@ -1339,7 +1341,7 @@ public void onInstallReferrersFinished() {
             @Override
             public void onAdsParamsFetchFinished() {
                 requestQueue_.unlockProcessWait(ServerRequest.PROCESS_WAIT_LOCK.GAID_FETCH_WAIT_LOCK);
-                requestQueue_.processNextQueueItem("onAdsParamsFetchFinished");
+                // processNextQueueItem call removed - modern queue processes automatically via unlockProcessWait
             }
         });
     }
@@ -1367,7 +1369,7 @@ void onIntentReady(@NonNull Activity activity) {
             Uri intentData = activity.getIntent().getData();
             readAndStripParam(intentData, activity);
         }
-        requestQueue_.processNextQueueItem("onIntentReady");
+        // processNextQueueItem call removed - modern queue processes automatically without manual trigger
     }
 
     /**

Branch-SDK/src/main/java/io/branch/referral/BranchRequestQueueAdapter.kt

@@ -67,13 +67,6 @@ class BranchRequestQueueAdapter private constructor(context: Context) {
         }
     }
 
-    /**
-     * Process next queue item - trigger processing
-     */
-    fun processNextQueueItem(callingMethodName: String) {
-        BranchLogger.v("processNextQueueItem $callingMethodName - processing is automatic in new queue")
-    }
-    
     /**
      * Queue operations - delegating to new queue implementation
      */

Branch-SDK/src/main/java/io/branch/referral/ServerRequestQueue.java

@@ -316,51 +316,6 @@ public void postInitClear() {
         }
     }
 
-    void processNextQueueItem(String callingMethodName) {
-        BranchLogger.v("processNextQueueItem " + callingMethodName);
-        this.printQueue();
-        try {
-            serverSema_.acquire();
-            if (networkCount_ == 0 && this.getSize() > 0) {
-                networkCount_ = 1;
-                ServerRequest req = this.peek();
-
-                serverSema_.release();
-                if (req != null) {
-                    BranchLogger.d("processNextQueueItem, req " + req);
-                    if (!req.isWaitingOnProcessToFinish()) {
-                        // All request except Install request need a valid RandomizedBundleToken
-                        if (!(req instanceof ServerRequestRegisterInstall) && !hasUser()) {
-                            BranchLogger.d("Branch Error: User session has not been initialized!");
-                            networkCount_ = 0;
-                            BranchLogger.v("Invoking " + req + " handleFailure. Has no session. hasUser: " + hasUser());
-                            req.handleFailure(BranchError.ERR_NO_SESSION, "Request " + req + " has no session.");
-                        }
-                        // Determine if a session is needed to execute (SDK-271)
-                        else if (requestNeedsSession(req) && !isSessionAvailableForRequest()) {
-                            networkCount_ = 0;
-                            BranchLogger.v("Invoking " + req + " handleFailure. Has no session.");
-                            req.handleFailure(BranchError.ERR_NO_SESSION, "Request " + req + " has no session.");
-                        } else {
-                            executeTimedBranchPostTask(req, Branch.getInstance().prefHelper_.getTaskTimeout());
-                        }
-                    }
-                    else {
-                        networkCount_ = 0;
-                    }
-                }
-                else {
-                    this.remove(null); //In case there is any request nullified remove it.
-                }
-            }
-            else {
-                serverSema_.release();
-            }
-        } catch (Exception e) {
-            BranchLogger.e("Caught Exception " + callingMethodName + " processNextQueueItem: " + e.getMessage() + " stacktrace: " + BranchLogger.stackTraceToString(e));
-        }
-    }
-
     void insertRequestAtFront(ServerRequest req) {
         BranchLogger.v("Queue operation insertRequestAtFront " + req + " networkCount_: " + networkCount_);
         if (networkCount_ == 0) {
@@ -487,7 +442,7 @@ public void handleNewRequest(ServerRequest req) {
         this.enqueue(req);
         req.onRequestQueued();
 
-        this.processNextQueueItem("handleNewRequest");
+        // Modern queue processes automatically after enqueue - no manual trigger needed
     }
 
     // If there is 1 (currently being removed) or 0 init requests in the queue, clear the init data
@@ -577,16 +532,9 @@ void onPostExecuteInner(ServerResponse serverResponse) {
             }
             ServerRequestQueue.this.networkCount_ = 0;
 
-            // In rare cases where this method is called directly (eg. when network calls time out),
-            // starting the next queue item can lead to stack over flow. Ensuring that this is
-            // queued back to the main thread mitigates this.
-            Handler handler = new Handler(Looper.getMainLooper());
-            handler.post(new Runnable() {
-                @Override
-                public void run() {
-                    ServerRequestQueue.this.processNextQueueItem("onPostExecuteInner");
-                }
-            });
+            // Modern queue processes automatically after request completion - no manual trigger needed
+            // Note: Original logic handled stack overflow by posting to main thread, but modern
+            // coroutines-based queue eliminates this issue through async processing
         }
 
         private void onRequestSuccess(ServerResponse serverResponse) {