SDK-1570 prep 1.43.2 release

Author: echo-branch

Branch-SDK/BNCConfig.m

@@ -11,4 +11,4 @@
 NSString * const BNC_API_BASE_URL    = @"https://api2.branch.io";
 NSString * const BNC_API_VERSION     = @"v1";
 NSString * const BNC_LINK_URL        = @"https://bnc.lt";
-NSString * const BNC_SDK_VERSION     = @"1.43.1";
+NSString * const BNC_SDK_VERSION     = @"1.43.2";

Branch-SDK/BNCNetworkService.m

@@ -124,10 +124,7 @@ - (NSURLSession*) session {
         self.sessionQueue = [NSOperationQueue new];
         self.sessionQueue.name = @"io.branch.sdk.network.queue";
         self.sessionQueue.maxConcurrentOperationCount = self.maximumConcurrentOperations;
-        if ([self.sessionQueue respondsToSelector:@selector(setQualityOfService:)]) {
-            // qualityOfService is iOS 8 and above.
-            self.sessionQueue.qualityOfService = NSQualityOfServiceUserInteractive;
-        }
+        self.sessionQueue.qualityOfService = NSQualityOfServiceBackground;
 
         _session =
             [NSURLSession sessionWithConfiguration:configuration

Branch-SDK/BNCPreferenceHelper.m

@@ -709,7 +709,6 @@ - (void) clearTrackingInformation {
          // Don't clear these
          self.randomizedDeviceToken = nil;
          self.randomizedBundleToken = nil;
-         self.userIdentity = nil;
          */
         self.sessionID = nil;
         self.linkClickIdentifier = nil;
@@ -726,6 +725,7 @@ - (void) clearTrackingInformation {
         self.previousAppBuildDate = nil;
         self.requestMetadataDictionary = nil;
         self.lastStrongMatchDate = nil;
+        self.userIdentity = nil;
     }
 }
 

Branch-SDK/BNCServerInterface.m

@@ -472,6 +472,11 @@ - (NSMutableDictionary *)prepareParamDict:(NSDictionary *)params
             }
         }
     }
+    
+    if ([self.requestEndpoint containsString:@"/v1/open"]) {
+        [fullParamDict bnc_safeSetObject:[BNCPreferenceHelper sharedInstance].userIdentity forKey:@"identity"];
+    }
+    
     return fullParamDict;
 }
 

Branch-SDK/BranchPluginSupport.m

@@ -28,28 +28,29 @@ + (BranchPluginSupport *)instance {
 
 
 - (NSDictionary<NSString *, NSString *> *)deviceDescription {
-    BNCDeviceInfo *deviceInfo = [BNCDeviceInfo getInstance];
-    [deviceInfo checkAdvertisingIdentifier];
-    
     NSMutableDictionary<NSString *, NSString *> *dictionary = [NSMutableDictionary new];
-        
-    [dictionary bnc_safeSetObject:deviceInfo.osName forKey:@"os"];
-    [dictionary bnc_safeSetObject:deviceInfo.osVersion forKey:@"os_version"];
-    [dictionary bnc_safeSetObject:deviceInfo.environment forKey:@"environment"];
-    [dictionary bnc_safeSetObject:deviceInfo.vendorId forKey:@"idfv"];
-    [dictionary bnc_safeSetObject:deviceInfo.advertiserId forKey:@"idfa"];
-    [dictionary bnc_safeSetObject:deviceInfo.optedInStatus forKey:@"opted_in_status"];
-    [dictionary bnc_safeSetObject:[BNCPreferenceHelper sharedInstance].userIdentity forKey:@"developer_identity"];
-    [dictionary bnc_safeSetObject:deviceInfo.country forKey:@"country"];
-    [dictionary bnc_safeSetObject:deviceInfo.language forKey:@"language"];
-    [dictionary bnc_safeSetObject:deviceInfo.localIPAddress forKey:@"local_ip"];
-    [dictionary bnc_safeSetObject:deviceInfo.brandName forKey:@"brand"];
-    [dictionary bnc_safeSetObject:deviceInfo.applicationVersion forKey:@"app_version"];
-    [dictionary bnc_safeSetObject:deviceInfo.modelName forKey:@"model"];
-    [dictionary bnc_safeSetObject:deviceInfo.screenScale.stringValue forKey:@"screen_dpi"];
-    [dictionary bnc_safeSetObject:deviceInfo.screenHeight.stringValue forKey:@"screen_height"];
-    [dictionary bnc_safeSetObject:deviceInfo.screenWidth.stringValue forKey:@"screen_width"];
+    BNCDeviceInfo *deviceInfo = [BNCDeviceInfo getInstance];
 
+    @synchronized (deviceInfo) {
+        [deviceInfo checkAdvertisingIdentifier];
+            
+        [dictionary bnc_safeSetObject:deviceInfo.osName forKey:@"os"];
+        [dictionary bnc_safeSetObject:deviceInfo.osVersion forKey:@"os_version"];
+        [dictionary bnc_safeSetObject:deviceInfo.environment forKey:@"environment"];
+        [dictionary bnc_safeSetObject:deviceInfo.vendorId forKey:@"idfv"];
+        [dictionary bnc_safeSetObject:deviceInfo.advertiserId forKey:@"idfa"];
+        [dictionary bnc_safeSetObject:deviceInfo.optedInStatus forKey:@"opted_in_status"];
+        [dictionary bnc_safeSetObject:[BNCPreferenceHelper sharedInstance].userIdentity forKey:@"developer_identity"];
+        [dictionary bnc_safeSetObject:deviceInfo.country forKey:@"country"];
+        [dictionary bnc_safeSetObject:deviceInfo.language forKey:@"language"];
+        [dictionary bnc_safeSetObject:deviceInfo.localIPAddress forKey:@"local_ip"];
+        [dictionary bnc_safeSetObject:deviceInfo.brandName forKey:@"brand"];
+        [dictionary bnc_safeSetObject:deviceInfo.applicationVersion forKey:@"app_version"];
+        [dictionary bnc_safeSetObject:deviceInfo.modelName forKey:@"model"];
+        [dictionary bnc_safeSetObject:deviceInfo.screenScale.stringValue forKey:@"screen_dpi"];
+        [dictionary bnc_safeSetObject:deviceInfo.screenHeight.stringValue forKey:@"screen_height"];
+        [dictionary bnc_safeSetObject:deviceInfo.screenWidth.stringValue forKey:@"screen_width"];
+    }
     return dictionary;
 }
 

Branch-TestBed/Framework-Info.plist

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = "Branch"
-  s.version          = "1.43.1"
+  s.version          = "1.43.2"
   s.summary          = "Create an HTTP URL for any piece of content in your app"
   s.description      = <<-DESC
 - Want the highest possible conversions on your sharing feature?

Branch.podspec

@@ -1,5 +1,9 @@
 Branch iOS SDK Change Log
 
+v.1.43.2
+- SDK-1625 Fix rare crash when used with Adobe Launch
+- Update developer id handling logic
+
 v.1.43.1
 - SDK-1461 Updates to GBRAID handling
 - Updated podspec to include LinkPresentation.framework

ChangeLog.md

@@ -1,3 +1,13 @@
-## Branch SDK Documentation for iOS
+# Branch SDK Documentation for iOS
+
+The Branch iOS SDK for deep linking and attribution.
+
+> ## Branch Sandbox Program
+>
+> As part of this [sandbox program](https://help.branch.io/developers-hub/docs/branch-sandbox-program), you will be able to partner directly with Branch’s Product and Engineering team for exclusive access to test drive our innovative products before the market and proactively exchange valuable feedback. With your support, we will create the winning measurement and linking solutions of the future together.
+> 
+> **If you would like to join, please reach out to us today at [[email protected]](mailto:[email protected] "mailto:[email protected]") or by filling out this [form](https://branch.link/sandbox?~channel=ios-repo).**
+
+Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
 
 View [Branch's SDK documentation for iOS](https://help.branch.io/developers-hub/docs/ios-sdk-overview)

README.md

@@ -0,0 +1,5 @@
+# Security Policy
+
+## Reporting a Vulnerability
+If you discover a potential security issue in this project we ask that you notify Branch Security directly via email to [email protected]
+Please do not open GitHub issues or pull requests - this makes the problem immediately visible to everyone, including malicious actors.