Skip to content

Commit 0b6afa4

Browse files
authored
Merge pull request #7 from BranchMetrics/staging
Fix for missing idfa
2 parents 699f047 + 78ce91d commit 0b6afa4

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

Branch.xcodeproj/project.pbxproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,6 +1184,7 @@
11841184
CODE_SIGN_IDENTITY = "Mac Developer";
11851185
CODE_SIGN_STYLE = Automatic;
11861186
DEVELOPMENT_TEAM = "";
1187+
MARKETING_VERSION = 1.2.1;
11871188
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
11881189
PROVISIONING_PROFILE_SPECIFIER = "";
11891190
};
@@ -1195,6 +1196,7 @@
11951196
CODE_SIGN_IDENTITY = "";
11961197
CODE_SIGN_STYLE = Automatic;
11971198
DEVELOPMENT_TEAM = "";
1199+
MARKETING_VERSION = 1.2.1;
11981200
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
11991201
PROVISIONING_PROFILE_SPECIFIER = "";
12001202
};
@@ -1298,6 +1300,7 @@
12981300
CODE_SIGN_IDENTITY = "";
12991301
CODE_SIGN_STYLE = Automatic;
13001302
DEVELOPMENT_TEAM = "";
1303+
MARKETING_VERSION = 1.2.1;
13011304
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
13021305
PROVISIONING_PROFILE_SPECIFIER = "";
13031306
};

Branch/BNCDevice.m

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,9 @@ - (NSString *)vendorID {
286286

287287
#endif
288288

289-
- (NSString*) hardwareID {
290-
NSString*s;
289+
- (NSString *)hardwareID {
290+
// INTENG-8458 server only wants hardware id and hardware id type for idfa and idfv.
291+
NSString *s = nil;
291292
s = [self advertisingID];
292293
if (s) {
293294
_hardwareIDType = @"idfa";
@@ -298,13 +299,6 @@ - (NSString*) hardwareID {
298299
_hardwareIDType = @"vendor_id";
299300
return s;
300301
}
301-
s = [self netAddress];
302-
if (s) {
303-
_hardwareIDType = @"mac_address";
304-
return s;
305-
}
306-
s = [[NSUUID UUID] UUIDString];
307-
_hardwareIDType = @"random";
308302
return s;
309303
}
310304

Branch/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>FMWK</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.2.0</string>
18+
<string>$(MARKETING_VERSION)</string>
1919
<key>CFBundleVersion</key>
2020
<string>1</string>
2121
<key>NSHumanReadableCopyright</key>

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
Branch Mac SDK Change Log
22

3+
## v1.2.1 - December 13, 2019
4+
* Fix crash when idfa is not available
5+
36
## v1.2.0 - October 7, 2019
47
* Add user agent
58
* Attribution fixes
0 Bytes
Binary file not shown.

Frameworks/macOS/Branch.framework/Versions/A/Resources/Info.plist

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<plist version="1.0">
44
<dict>
55
<key>BuildMachineOSBuild</key>
6-
<string>18G95</string>
6+
<string>18G1012</string>
77
<key>CFBundleDevelopmentRegion</key>
88
<string>en</string>
99
<key>CFBundleExecutable</key>
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>FMWK</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>1.2.0</string>
20+
<string>1.2.1</string>
2121
<key>CFBundleSupportedPlatforms</key>
2222
<array>
2323
<string>MacOSX</string>
@@ -27,17 +27,17 @@
2727
<key>DTCompiler</key>
2828
<string>com.apple.compilers.llvm.clang.1_0</string>
2929
<key>DTPlatformBuild</key>
30-
<string>11A1027</string>
30+
<string>11C29</string>
3131
<key>DTPlatformVersion</key>
3232
<string>GM</string>
3333
<key>DTSDKBuild</key>
34-
<string>19A547</string>
34+
<string>19B90</string>
3535
<key>DTSDKName</key>
3636
<string>macosx10.15</string>
3737
<key>DTXcode</key>
38-
<string>1110</string>
38+
<string>1130</string>
3939
<key>DTXcodeBuild</key>
40-
<string>11A1027</string>
40+
<string>11C29</string>
4141
<key>LSMinimumSystemVersion</key>
4242
<string>10.10</string>
4343
<key>NSHumanReadableCopyright</key>

0 commit comments

Comments
 (0)