Skip to content

Commit acba1f9

Browse files
authored
[other] a couple more deploy cleanups (#1089)
# Pull Request Template ## Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Unit test - [ ] Integration test ## JS Budget Check Please mention the size in kb before abd after this PR | Files | Before | After | | ----------- | ----------- | ----------- | | dist/build.js. | | | | dist/build.min.js| | | ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings ## Mentions: List the person or team responsible for reviewing proposed changes. cc @BranchMetrics/saas-sdk-devs for visibility.
1 parent 441102e commit acba1f9

File tree

7 files changed

+10
-5
lines changed

7 files changed

+10
-5
lines changed

.github/workflows/deploy-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ jobs:
6161
with:
6262
node-version: ${{ env.NODE_VERSION }}
6363

64+
# Do this before npm configure because it writes the package.json version
6465
- name: Write version to files
6566
run: |
6667
./deployment/write-versions.sh ${{ steps.next-version.outputs.result }}

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ All notable changes to the Branch Web SDK will be documented here.
33
The Branch Web SDK adheres to [Semantic Versioning](http://semver.org/).
44

55
## [VERSION] - unreleased
6+
## [2.85.2] - 2024-11-11
7+
- Updates release process
68
## [2.85.1] - 2024-11-04
79
- Updates qr image download to avoid errors
810
## [2.85.0] - 2024-04-10

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ all: dist/build.min.js dist/build.js test/branch-deps.js test/integration-test.h
3737
clean:
3838
rm -f dist/** docs/web/3_branch_web.md test/branch-deps.js dist/build.min.js.gz test/integration-test.html
3939
release: clean all dist/build.min.js.gz
40-
@echo "released"
4140

4241
test/branch-deps.js: $(SOURCES)
4342
npx closure-make-deps \

deployment/release-s3.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ make release
1414
aws s3 cp example.html s3://branch-builds/example.html
1515
aws s3 cp example.html s3://branch-cdn/example.html
1616

17+
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.js s3://branch-cdn/branch-latest.js --cache-control "max-age=300"
1718
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-$VERSION.min.js --cache-control "max-age=300"
1819
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-latest.min.js --cache-control "max-age=300"
1920

2021
echo -en "Invalidating cloudfront distribution...\n"
2122
aws configure set preview.cloudfront true
2223
aws cloudfront create-invalidation --distribution-id E10P37NG0GMER --paths /branch-latest.min.js
2324

24-
2525
echo "Post-release sanity checks."
2626
read -p "Can you visit https://cdn.branch.io/branch-$VERSION.min.js ?" -n 1 -r
2727
echo

examples/example.template.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,8 @@ <h4>QR Code</h4>
250250
"background_color": "#FFFFFF",
251251
"margin": 5,
252252
"width": 1000,
253-
"image_format": "png"
253+
"image_format": "png",
254+
"center_logo_url": "https://branch-assets.s3.us-west-1.amazonaws.com/branch-badge-dark.svg",
254255
};
255256
var qrCodeParams = {
256257
tags: [ 'tag1', 'tag2' ],

src/0_config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ var DEFAULT_API_ENDPOINT = 'https://api2.branch.io';
88
config.app_service_endpoint = 'https://app.link';
99
config.link_service_endpoint = 'https://bnc.lt';
1010
config.api_endpoint = DEFAULT_API_ENDPOINT;
11-
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
11+
// will get overwritten by gha on actual deploy
12+
config.version = '2.85.2';

test/web-config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ goog.provide('config');
66
config.app_service_endpoint = 'https://app.link';
77
config.link_service_endpoint = 'https://bnc.lt';
88
config.api_endpoint = 'https://api.branch.io';
9-
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
9+
// will get overwritten by gha on actual deploy
10+
config.version = '2.85.2';

0 commit comments

Comments
 (0)