ci(core): add new npm scripts for clean, coverage (#905)

* ci(core): add new npm scripts for clean, coverage

add new npm run script for clean, coverage, build

 moved google closure to dev dependencies

updated sinon package to latest

* ci(core): add GHA to publish unit test results

add GHA to publish unit test results

* ci(core): publish unit test results as PR comment

publish unit test results as PR comment

* chore(ci): add codecov to gate-keep.yml

* chore(other): add lcov format for nyc reporting

add lcov format for nyc reporting

* test(core): add config unit tests

add config unit tests

* test(core): add config unit tests

add config unit tests

* test(core): modify test/branch-deps to include config unit tests

modify test/branch-deps to include config unit tests

Author: JagadeeshKaricherla-branch

.github/workflows/deploy-qa.yml

@@ -28,17 +28,20 @@ jobs:
           cache: 'npm'
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Run tests
         id: runTests
         run: npm run test
 
+      - name: Run coverage
+        id: runCover
+        if: steps.runTests.outcome == 'success'
+        run: npm run cover
+
       - name : upload codecov
         uses: codecov/codecov-action@v3
-        if: steps.runTests.outcome == 'success'
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
+        if: steps.runCover.outcome == 'success'
 
   test-lint:
     name: Lint
@@ -54,7 +57,7 @@ jobs:
           cache: 'npm'
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Lint tests
         run: npm run lint
@@ -80,7 +83,7 @@ jobs:
           distribution: ${{ env.JAVA_DISTRIBUTION }}
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Call the Build bash script for QA
         id: build

.github/workflows/gate-keep.yml

@@ -3,13 +3,12 @@ on:
   pull_request:
     types: [opened,reopened,edited,synchronize]
     branches:
-      - main
+      - master
       - production
     paths-ignore:
       - docs/**
       - README.md
 env:
-  BRANCH_NAME: '${{ github.event.inputs.branch_name || github.head_ref || github.ref_name  }}'
   NODE_VERSION: 16
   JAVA_VERSION: 11
   JAVA_DISTRIBUTION: 'adopt'
@@ -29,10 +28,32 @@ jobs:
           cache: 'npm'
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Run tests
-        run: npm run test
+        run: npm run test-report
+
+      - name: Test Report
+        uses: dorny/test-reporter@v1
+        if: success() || failure()
+        with:
+           name: Unit Tests
+           fail-on-error: true,
+           path: test-results.json    # Path to test results
+           reporter: mocha-json        # Format of test results
+
+      - name: Publish Test Results
+        uses: EnricoMi/publish-unit-test-result-action@v2
+        id: test-results
+        if: always()
+        with:
+          files: "test-results.json"
+
+      - name: Run cover
+        run: npm run cover
+
+      - name : upload codecov
+        uses: codecov/codecov-action@v3
 
   test-lint:
     name: Lint
@@ -48,7 +69,7 @@ jobs:
           cache: 'npm'
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Lint tests
         run: npm run lint
@@ -73,7 +94,7 @@ jobs:
           distribution: ${{ env.JAVA_DISTRIBUTION }}
 
       - name: Install dependencies
-        run: npm install
+        run: npm run ci
 
       - name: Call the Build bash script for QA
         run:  bash ${GITHUB_WORKSPACE}/deployment/build-test.sh

.gitignore

@@ -33,3 +33,4 @@ local-testbench
 index.html
 dist
 .nyc_output
+test-results.json

.mocharc.js

@@ -7,5 +7,5 @@
 
 module.exports = {
   require: ['./node_modules/google-closure-library', './test/branch-deps.js', './node_modules/jsdom-global/register.js', './test/test-utils.js', './node_modules/sinon/lib/sinon.js'],
-  spec: ['./test/1_utils.js','./test/6_branch_new.js', './test/journeys_utils.js']
+  spec: ['./test/0_config.js','./test/1_utils.js','./test/6_branch_new.js', './test/journeys_utils.js']
 };

.nycrc

@@ -1,8 +1,10 @@
 {
     "reporter": [
         "text-summary",
-        "html"
+        "html",
+        "lcov"
     ],
+    "all": true,
     "include": [
         "src/**"
     ],

Makefile

@@ -43,10 +43,8 @@ test/branch-deps.js: $(SOURCES)
 		--f node_modules/google-closure-library/closure/goog/deps.js \
 		--root src \
 		--root test \
-		--exclude src/0_config.js \
-		--exclude test/branch-deps.js > test/branch-deps.js.tmp
-	echo "// jscs:disable" | cat - test/branch-deps.js.tmp | sed -e 's#src/0_config.js#test/web-config.js#' > test/branch-deps.js && \
-		rm test/branch-deps.js.tmp
+		--exclude test/web-config.js \
+		--exclude test/branch-deps.js > test/branch-deps.js
 
 dist/build.js: $(SOURCES) $(EXTERN)
 	mkdir -p dist && \