Commit ef478c7
authored
[minor] Have Screen Speak/screen readers on mobile read Journey before other page content. (#1088)
# Pull Request Template
## Description
For mobile, changed appendChild to prepend so the journey is at the top
of the HTML and is read first by screen readers.
Fixes # (issue)
[ENGMT-1629](https://branch.atlassian.net/browse/ENGMT-1629)
## Type of change
Please delete options that are not relevant.
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
## How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
- [ ] Unit test
- [ ] Integration test
- [ ] Manual testing. Journey's unit tests are commented out (have been
for years it looks like?). Manual testing videos are visible in the JIRA
ticket.
## JS Budget Check
Please mention the size in kb before abd after this PR
| Files | Before | After |
| ----------- | ----------- | ----------- |
| dist/build.js. | 166KB | 166KB |
| dist/build.min.js| 77KB | 77KB |
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [] I have commented my code, particularly in hard-to-understand areas
- [] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [x] I have checked my code and corrected any misspellings
## Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.
[ENGMT-1629]:
https://branch.atlassian.net/browse/ENGMT-1629?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ1 parent 9043225 commit ef478c7
2 files changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
0 commit comments