Skip to content

Commit f9647fb

Browse files
committed
[patch] inteng-23549: add null checks for parentNode
1 parent 34b3814 commit f9647fb

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/2_session.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ session.get = function(storage, first) {
2929
* @param {boolean=} first
3030
*/
3131
session.set = function(storage, data, first) {
32-
3332
if (first && data['referring_link'] && utils.userPreferences.enableExtendedJourneysAssist) {
3433
var now = new Date();
3534
data['referringLinkExpiry'] = now.getTime() + utils.extendedJourneysAssistExpiryTime;

src/3_banner_utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ banner_utils.error_timeout = 2000;
5757
* @param {Object} element
5858
*/
5959
banner_utils.removeElement = function(element) {
60-
if (element) {
60+
if (element && element.parentNode) {
6161
element.parentNode.removeChild(element);
6262
}
6363
};

src/branch_view.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@ branch_view.displayJourney = function(html, requestData, templateId, branchViewD
141141
var audienceRuleId = branchViewData['audience_rule_id'];
142142

143143
// this code removes any leftover css from previous banner
144-
var branchCSS = document.getElementById('branch-iframe-css')
145-
if (branchCSS) {
146-
branchCSS.parentElement.removeChild(branchCSS)
144+
var branchCSS = document.getElementById('branch-iframe-css');
145+
if (branchCSS && branchCSS.parentElement) {
146+
branchCSS.parentElement.removeChild(branchCSS);
147147
}
148148

149149
var placeholder = document.createElement('div');

0 commit comments

Comments
 (0)