fix: update source and tests for Elasticsearch 9 compatibility

- Wrap native ES9 client calls in Index::delete(), Index::create(),
  Pipeline::deletePipeline(), and Reindex::run() with try/catch to
  convert ClientResponseException/ServerResponseException into
  Elastica ResponseException
- Fix test assertions for ES9 breaking changes: document_parsing_exception,
  removed boost mapping param, removed Common query (replaced with BoolQuery
  should clauses + minimum_should_match), from/to range params replaced with
  gte/lte, _id fielddata disabled, reindex 409 conflict behavior,
  allowlist/whitelist regex, coordinate deltas, percentile tolerance,
  percentile keys returned as floats, sort by seq field
- Restore cosmetic-only files from opensearch baseline and apply
  minimal CS Fixer 3.94.2 formatting
- Disable non-ES9 cosmetic CS rules in .php-cs-fixer.dist.php

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: sumitkhopade1986

.github/workflows/php-upgrade-rector-proposals.yml

@@ -0,0 +1,19 @@
+name: PHP Upgrade Rector Proposals
+
+on:
+  workflow_dispatch:
+    inputs:
+      PHP_TARGET_VERSION:
+        required: true
+        type: string
+        description: 'Target PHP version (e.g. 8.4)'
+        default: '8.4'
+
+jobs:
+  rector-php-upgrade:
+    uses: BrandEmbassy/github-actions/.github/workflows/php-upgrade-rector-proposals.yml@master
+    with:
+      PHP_TARGET_VERSION: ${{ inputs.PHP_TARGET_VERSION }}
+      RECTOR_PATHS: 'src tests'
+    secrets:
+      COMPOSER_TOKEN: ${{ secrets.COMPOSER_TOKEN }}

.php-cs-fixer.dist.php

@@ -16,19 +16,44 @@
         'is_null' => true,
         'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],
         'native_constant_invocation' => true,
-        'native_function_invocation' => [
-            'include' => ['@all'],
-        ],
+        'native_function_invocation' => false,
         'no_alias_functions' => true,
         'no_useless_else' => true,
         'nullable_type_declaration_for_default_null_value' => true,
         'ordered_imports' => true,
         'php_unit_dedicate_assert' => ['target' => 'newest'],
         'php_unit_test_class_requires_covers' => false,
-        'phpdoc_order' => true,
+        'phpdoc_order' => false,
         'phpdoc_types_order' => ['null_adjustment' => 'always_last'],
         'static_lambda' => true,
         'ternary_to_null_coalescing' => true,
         'visibility_required' => ['elements' => ['property', 'method', 'const']],
+        'phpdoc_no_useless_inheritdoc' => false,
+        'no_superfluous_phpdoc_tags' => false,
+        'global_namespace_import' => false,
+        'trailing_comma_in_multiline' => false,
+        'fully_qualified_strict_types' => false,
+        'phpdoc_separation' => false,
+        'new_with_parentheses' => false,
+        'escape_implicit_backslashes' => false,
+        'declare_strict_types' => false,
+        'no_unneeded_control_parentheses' => false,
+        'string_implicit_backslashes' => false,
+        'phpdoc_no_alias_tag' => ['replacements' => ['type' => 'var', 'link' => 'see']],
+        'yoda_style' => false,
+        'curly_braces_position' => false,
+        'braces_position' => false,
+        'no_extra_blank_lines' => false,
+        'blank_line_after_opening_tag' => false,
+        'cast_spaces' => false,
+        'native_constant_invocation' => false,
+        'single_line_throw' => false,
+        'declare_parentheses' => false,
+        'class_attributes_separation' => false,
+        'linebreak_after_opening_tag' => false,
+        'declare_equal_normalize' => false,
+        'blank_line_between_import_groups' => false,
+        'single_quote' => false,
+        'ordered_class_elements' => false,
     ])
 ;

phpstan-baseline.neon

@@ -90,6 +90,11 @@ parameters:
 			count: 1
 			path: tests/DocumentTest.php
 
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 2
+			path: tests/Multi/SearchTest.php
+
 		-
 			message: "#^Call to an undefined method ReflectionType\\:\\:getName\\(\\)\\.$#"
 			count: 2

src/Aggregation/AbstractAggregation.php

@@ -79,8 +79,8 @@ public function addAggregation(AbstractAggregation $aggregation): self
      * Add metadata to the aggregation.
      *
      * @see https://www.elastic.co/guide/en/elasticsearch/reference/current/agg-metadata.html
-     * @see AbstractAggregation::getMeta()
-     * @see AbstractAggregation::clearMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::getMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::clearMeta()
      *
      * @param array $meta Metadata to be attached to the aggregation
      *
@@ -101,8 +101,8 @@ public function setMeta(array $meta): self
      * Retrieve the currently configured metadata for the aggregation.
      *
      * @see https://www.elastic.co/guide/en/elasticsearch/reference/current/agg-metadata.html
-     * @see AbstractAggregation::setMeta()
-     * @see AbstractAggregation::clearMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::setMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::clearMeta()
      */
     public function getMeta(): ?array
     {
@@ -113,8 +113,8 @@ public function getMeta(): ?array
      * Clears any previously set metadata for this aggregation.
      *
      * @see https://www.elastic.co/guide/en/elasticsearch/reference/current/agg-metadata.html
-     * @see AbstractAggregation::setMeta()
-     * @see AbstractAggregation::getMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::setMeta()
+     * @see \Elastica\Aggregation\AbstractAggregation::getMeta()
      *
      * @return $this
      */

src/Aggregation/AbstractSimpleAggregation.php

@@ -30,6 +30,9 @@ public function setScript($script): self
         return $this->setParam('script', $script);
     }
 
+    /**
+     * {@inheritdoc}
+     */
     public function toArray(): array
     {
         if (!$this->hasParam('field') && !$this->hasParam('script')) {

src/Aggregation/ReverseNested.php

@@ -32,6 +32,9 @@ public function setPath(string $path): self
         return $this->setParam('path', $path);
     }
 
+    /**
+     * {@inheritdoc}
+     */
     public function toArray(): array
     {
         $array = parent::toArray();

src/Aggregation/ScriptedMetric.php

@@ -21,7 +21,7 @@ public function __construct(
         ?string $initScript = null,
         ?string $mapScript = null,
         ?string $combineScript = null,
-        ?string $reduceScript = null,
+        ?string $reduceScript = null
     ) {
         parent::__construct($name);
         if ($initScript) {

src/Aggregation/Traits/MissingTrait.php

@@ -7,6 +7,8 @@ trait MissingTrait
     /**
      * Defines how documents that are missing a value should be treated.
      *
+     * @param mixed $missing
+     *
      * @return $this
      */
     public function setMissing($missing): self

src/Aggregation/WeightedAvg.php

@@ -14,7 +14,7 @@ class WeightedAvg extends AbstractAggregation
     /**
      * Set the value for this aggregation.
      *
-     * @param mixed|null $missing
+     * @param mixed $missing
      *
      * @return $this
      */
@@ -50,7 +50,7 @@ public function setValueScript(string $script)
     /**
      * Set the weight for this aggregation.
      *
-     * @param mixed|null $missing
+     * @param mixed $missing
      *
      * @return $this
      */
@@ -98,6 +98,8 @@ public function setFormat($format)
     /**
      * Set the value_type for this aggregation.
      *
+     * @param mixed $valueType
+     *
      * @return $this
      */
     public function setValueType($valueType)

src/Bulk/Action.php

@@ -2,6 +2,7 @@
 
 namespace Elastica\Bulk;
 
+use Closure;
 use Elastica\Bulk;
 use Elastica\Index;
 use Elastica\JSON;
@@ -40,7 +41,7 @@ class Action
 
     protected int $apiVersion;
 
-    protected \Closure $documentTypeResolver;
+    protected Closure $documentTypeResolver;
 
     public function __construct(string $opType = self::OP_TYPE_INDEX, array $metadata = [], array $source = [])
     {
@@ -73,11 +74,18 @@ public function __toString(): string
         return $string;
     }
 
+    /**
+     * @return int
+     */
     public function getApiVersion(): int
     {
         return $this->apiVersion;
     }
 
+
+    /**
+     * @param int $apiVersion
+     */
     public function setApiVersion(int $apiVersion): void
     {
         $this->apiVersion = $apiVersion;