stringtable - fix escaped char (&) in stringtables (#845)

* stringtable - fix escaped char (`&`) in stringtables

* Warn and skip file if phrase in unescapeable

* fmt

Author: PabstMirror

libs/stringtable/src/rapify.rs

@@ -1,6 +1,6 @@
 use crate::{Key, Project, ALL_LANGUAGES};
 use hemtt_workspace::WorkspacePath;
-use tracing::trace;
+use tracing::{trace, warn};
 
 #[derive(Default, Debug)]
 pub struct XmlbLayout {
@@ -137,7 +137,12 @@ pub fn rapify(project: &Project) -> Option<XmlbLayout> {
                 i32::try_from(translation.phrases.len()).expect("overflow"),
             );
             for phrase in &translation.phrases {
-                write_string(&mut translation_buffer, phrase);
+                let unescaped = quick_xml::escape::unescape(phrase.as_str());
+                if unescaped.is_err() {
+                    warn!("failed to unescape stringtable entry [{}]", phrase);
+                    return None;
+                }
+                write_string(&mut translation_buffer, &unescaped.unwrap_or_default());
             }
             rolling_offset += translation_buffer.len();
             data.translations.push(translation_buffer);