config: C14 Check unused externs (#1009)

* config: C14 Check unused externs

* indexmap, add test

* clippy

* config: enable c14 by default (#1016)

* config: enable c14 by default

* change message

* Update bin/src/commands/check.rs

Co-authored-by: PabstMirror <[email protected]>

---------

Co-authored-by: PabstMirror <[email protected]>

* Always create .hemttout (for testing)

---------

Co-authored-by: BrettMayson <[email protected]>

Author: PabstMirror

Cargo.lock

@@ -27,6 +27,9 @@ pub struct CheckArgs {
     #[arg(long, short = 'p', action = clap::ArgAction::SetTrue)]
     /// Run all lints that are disabled by default (but not explicitly disabled via project config)
     pedantic: bool,
+    #[arg(long, short = 'L', action = clap::ArgAction::Append)]
+    /// Explicit Lints
+    lints: Vec<String>,
 }
 
 /// Execute the check command
@@ -46,6 +49,16 @@ pub fn execute(cmd: &Command) -> Result<Report, Error> {
         ctx = ctx.with_config(config);
     }
 
+    if !cmd.check.lints.is_empty() {
+        let runtime = ctx
+            .config()
+            .runtime()
+            .clone()
+            .with_explicit_lints(cmd.check.lints.clone());
+        let config = ctx.config().clone().with_runtime(runtime);
+        ctx = ctx.with_config(config);
+    }
+
     let mut executor = Executor::new(ctx);
     global_modules(&mut executor);
 

bin/src/commands/check.rs

@@ -51,10 +51,9 @@ impl Module for Rapifier {
 
     fn check(&self, ctx: &Context) -> Result<Report, Error> {
         let mut report = Report::new();
-        let default_enabled = ctx.config().runtime().is_pedantic();
         report.extend(lint_check(
             ctx.config().lints().config().clone(),
-            default_enabled,
+            ctx.config().runtime().clone(),
         ));
         Ok(report)
     }

bin/src/modules/rapifier.rs

@@ -46,10 +46,9 @@ impl Module for SQFCompiler {
 
     fn check(&self, ctx: &Context) -> Result<Report, Error> {
         let mut report = Report::new();
-        let default_enabled = ctx.config().runtime().is_pedantic();
         report.extend(lint_check(
             ctx.config().lints().sqf().clone(),
-            default_enabled,
+            ctx.config().runtime().clone(),
         ));
         Ok(report)
     }

bin/src/modules/sqf.rs

@@ -37,10 +37,9 @@ impl Module for Stringtables {
 
     fn check(&self, ctx: &crate::context::Context) -> Result<crate::report::Report, crate::Error> {
         let mut report = Report::new();
-        let default_enabled = ctx.config().runtime().is_pedantic();
         report.extend(lint_check(
             ctx.config().lints().stringtables().clone(),
-            default_enabled,
+            ctx.config().runtime().clone(),
         ));
         Ok(report)
     }

bin/src/modules/stringtables.rs

@@ -12,7 +12,7 @@ pub use addon::AddonConfig;
 pub use pdrive::PDriveOption;
 pub use project::{
     ProjectConfig,
-    hemtt::launch::LaunchOptions,
+    hemtt::{RuntimeArguments, launch::LaunchOptions},
     lint::{LintConfig, LintConfigOverride, LintEnabled},
 };
 

libs/common/src/config/mod.rs

@@ -4,7 +4,7 @@ pub mod dev;
 pub mod launch;
 pub mod release;
 
-use std::{collections::HashMap, path::Path};
+use std::{collections::HashMap, path::Path, sync::Arc};
 
 use launch::LaunchOptions;
 use serde::{Deserialize, Serialize};
@@ -58,6 +58,8 @@ pub struct RuntimeArguments {
     is_release: bool,
     is_pedantic: bool,
     is_just: bool,
+
+    explicit_lints: Arc<[String]>,
 }
 
 impl RuntimeArguments {
@@ -67,7 +69,7 @@ impl RuntimeArguments {
     }
 
     #[must_use]
-    pub const fn with_release(self, is_release: bool) -> Self {
+    pub fn with_release(self, is_release: bool) -> Self {
         Self { is_release, ..self }
     }
 
@@ -77,7 +79,7 @@ impl RuntimeArguments {
     }
 
     #[must_use]
-    pub const fn with_pedantic(self, is_pedantic: bool) -> Self {
+    pub fn with_pedantic(self, is_pedantic: bool) -> Self {
         Self {
             is_pedantic,
             ..self
@@ -90,9 +92,22 @@ impl RuntimeArguments {
     }
 
     #[must_use]
-    pub const fn with_just(self, is_just: bool) -> Self {
+    pub fn with_just(self, is_just: bool) -> Self {
         Self { is_just, ..self }
     }
+
+    #[must_use]
+    pub fn explicit_lints(&self) -> &[String] {
+        &self.explicit_lints
+    }
+
+    #[must_use]
+    pub fn with_explicit_lints(self, explicit_lints: Vec<String>) -> Self {
+        Self {
+            explicit_lints: explicit_lints.into(),
+            ..self
+        }
+    }
 }
 
 #[allow(clippy::module_name_repetitions)]

libs/common/src/config/project/hemtt/mod.rs

@@ -19,6 +19,7 @@ hemtt-workspace = { path = "../workspace" }
 automod = { workspace = true }
 byteorder = { workspace = true }
 chumsky = { workspace = true }
+indexmap = { workspace = true }
 linkme = { workspace = true }
 lsp-types = { workspace = true }
 toml = { workspace = true }

libs/config/Cargo.toml

@@ -63,6 +63,7 @@ impl LintRunner<LintData> for RunnerValue {
         _project: Option<&ProjectConfig>,
         _config: &LintConfig,
         processed: Option<&Processed>,
+        _runtime: &hemtt_common::config::RuntimeArguments,
         target: &Value,
         _data: &LintData,
     ) -> Codes {
@@ -92,6 +93,7 @@ impl LintRunner<LintData> for RunnerItem {
         _project: Option<&ProjectConfig>,
         _config: &LintConfig,
         processed: Option<&Processed>,
+        _runtime: &hemtt_common::config::RuntimeArguments,
         target: &Item,
         _data: &LintData,
     ) -> Codes {

libs/config/src/analyze/lints/c01_invalid_value.rs

@@ -67,6 +67,7 @@ impl LintRunner<LintData> for Runner {
         _project: Option<&ProjectConfig>,
         _config: &LintConfig,
         processed: Option<&Processed>,
+        _runtime: &hemtt_common::config::RuntimeArguments,
         target: &Config,
         _data: &LintData,
     ) -> Codes {