Merge branch 'master' into switch-save-to-new-action-button

Author: Stropdasman

.github/workflows/readme-openapi.yml

@@ -13,7 +13,7 @@ git status --porcelain > "$before_lint_status"
 git diff --binary > "$before_lint_diff"
 git diff --cached --binary > "$before_lint_cached_diff"
 
-yarn lint:fix || {
+BUDIBASE_ALLOW_LINT_WARNINGS=1 yarn lint:fix || {
   printf >&2 "\n%s\n\n" "Linting failed. Push halted."
   exit 1
 }

.husky/pre-push

@@ -42,6 +42,8 @@
   on intermediate states. Just assert the final outcome
   against, provided there are no type errors.
 - Avoid adding nested ternary statements.
+- Prefer a svelte5 approach over svelte4.
+- Don't use // @ts-nocheck when asked to fix type errors.
 - When writing tests involving a URL, use example.com as the domain.
 
 ## Test style - packages/server

CLAUDE.md

@@ -108,6 +108,9 @@ $ helm install --create-namespace --namespace budibase budibase . -f values.yaml
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | affinity | object | `{}` | Sets the affinity for all pods created by this chart. Should not ordinarily need to be changed.  See <https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/> for more information on affinity. |
+| awsAlbIngress.accessLogs.bucket | string | `""` |  |
+| awsAlbIngress.accessLogs.enabled | bool | `false` | ALB access logging to S3. The bucket must already exist in the same region as the ALB, with a bucket policy allowing the regional ELB log-delivery principal to write to it. |
+| awsAlbIngress.accessLogs.prefix | string | `""` | Object key prefix within the bucket (logs land under <prefix>/AWSLogs/...). |
 | awsAlbIngress.certificateArn | string | `""` | If you're wanting to use HTTPS, you'll need to create an ACM certificate and specify the ARN here. |
 | awsAlbIngress.enabled | bool | `false` | Whether to create an ALB Ingress resource pointing to the Budibase proxy. Requires the AWS ALB Ingress Controller. |
 | couchdb.clusterSize | int | `1` | The number of replicas to run in the CouchDB cluster. We set this to 1 by default to make things simpler, but you can set it to 3 if you need a high-availability CouchDB cluster. |
@@ -216,6 +219,7 @@ $ helm install --create-namespace --namespace budibase budibase . -f values.yaml
 | services.proxy.livenessProbe | object | HTTP health checks. | Liveness probe configuration for proxy pods. You shouldn't need to change this, but if you want to you can find more information here: <https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/> |
 | services.proxy.readinessProbe | object | HTTP health checks. | Readiness probe configuration for proxy pods. You shouldn't need to change this, but if you want to you can find more information here: <https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/> |
 | services.proxy.replicaCount | int | `1` | The number of proxy replicas to run. |
+| services.proxy.resolver | string | `""` | The DNS resolver the nginx proxy uses to resolve upstreams at request time. MUST be an IP address (nginx resolves this once at config-load and exits fatally if it is an unresolvable DNS name). Leave empty to auto-detect the kube-dns ClusterIP at install/upgrade time; only set this if auto-detection cannot run (e.g. restricted RBAC for `lookup`). |
 | services.proxy.resources | object | `{}` | The resources to use for proxy pods. See <https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/> for more information on how to set these. |
 | services.proxy.startupProbe | object | HTTP health checks. | Startup probe configuration for proxy pods. You shouldn't need to change this, but if you want to you can find more information here: <https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/> |
 | services.redis.enabled | bool | `true` | Whether or not to deploy a Redis pod into your cluster. |

charts/budibase/README.md

@@ -10,6 +10,9 @@ metadata:
     alb.ingress.kubernetes.io/success-codes: '200'
     alb.ingress.kubernetes.io/healthcheck-path: '/health'
     alb.ingress.kubernetes.io/target-group-attributes: deregistration_delay.timeout_seconds={{ .Values.awsAlbIngress.deregistrationDelay }}
+    {{- if .Values.awsAlbIngress.accessLogs.enabled }}
+    alb.ingress.kubernetes.io/load-balancer-attributes: access_logs.s3.enabled=true,access_logs.s3.bucket={{ required "awsAlbIngress.accessLogs.bucket is required when awsAlbIngress.accessLogs.enabled is true" .Values.awsAlbIngress.accessLogs.bucket }},access_logs.s3.prefix={{ .Values.awsAlbIngress.accessLogs.prefix }}
+    {{- end }}
     {{- if .Values.awsAlbIngress.certificateArn }}
     alb.ingress.kubernetes.io/ssl-redirect: '443'
     alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80}, {"HTTPS":443}]'

charts/budibase/templates/alb-ingress.yaml

@@ -89,11 +89,13 @@ spec:
           value: {{ .Values.services.proxy.proxyRateLimitApiPerSecond | quote }}
         {{ end }}
         - name: RESOLVER
-          {{ if .Values.services.proxy.resolver }}
-          value: {{ .Values.services.proxy.resolver }}
-          {{ else }}
-          value: kube-dns.kube-system.svc.{{ .Values.services.dns }}
-          {{ end }}
+          {{- if .Values.services.proxy.resolver }}
+          value: {{ .Values.services.proxy.resolver | quote }}
+          {{- else if (lookup "v1" "Service" "kube-system" "kube-dns") }}
+          value: {{ (lookup "v1" "Service" "kube-system" "kube-dns").spec.clusterIP | quote }}
+          {{- else }}
+          value: {{ printf "kube-dns.kube-system.svc.%s" .Values.services.dns | quote }}
+          {{- end }}
         {{ with .Values.services.proxy.resources }}
         resources:
         {{- toYaml . | nindent 10 }}
@@ -119,7 +121,7 @@ spec:
     {{- end }}
       {{ if .Values.schedulerName }}
       schedulerName: {{ .Values.schedulerName | quote }}
-      {{ end }} 
+      {{ end }}
       {{ if .Values.imagePullSecrets }}
       imagePullSecrets:
       {{- toYaml .Values.imagePullSecrets | nindent 6 }}

charts/budibase/templates/proxy-service-deployment.yaml

@@ -53,6 +53,14 @@ awsAlbIngress:
   # -- Time in seconds ALB waits for in-flight requests during target deregistration.
   # This allows graceful connection draining during pod rollouts.
   deregistrationDelay: 30
+  # -- ALB access logging to S3.
+  # The bucket must already exist in the same region as the ALB, with a bucket policy
+  # allowing the regional ELB log-delivery principal to write to it.
+  accessLogs:
+    enabled: false
+    bucket: ""
+    # -- Object key prefix within the bucket (logs land under <prefix>/AWSLogs/...).
+    prefix: ""
 
 # -- Sets the tolerations for all pods created by this chart. Should not ordinarily need to be changed.
 # See <https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/> for more information
@@ -170,6 +178,13 @@ services:
     port: 10000
     # -- The number of proxy replicas to run.
     replicaCount: 2
+    # -- The DNS resolver the nginx proxy uses to resolve upstreams at request time.
+    # MUST be an IP address (nginx resolves this once at config-load and exits fatally
+    # if it is an unresolvable DNS name). Leave empty to auto-detect the kube-dns
+    # ClusterIP at install/upgrade time; only set this if auto-detection cannot run
+    # (e.g. restricted RBAC for `lookup`) — then use your cluster's DNS ClusterIP,
+    # e.g. `kubectl -n kube-system get svc kube-dns -o jsonpath='{.spec.clusterIP}'`.
+    resolver: ""
     # @ignore (you should never need to change this)
     upstreams:
       apps: "http://app-service.{{ .Release.Namespace }}.svc.{{ .Values.services.dns }}:{{ .Values.services.apps.port }}"
@@ -330,7 +345,9 @@ services:
       # @ignore
       periodSeconds: 3
       # @ignore
-      failureThreshold: 1
+      failureThreshold: 3
+      # @ignore
+      timeoutSeconds: 5
     # -- Liveness probe configuration for apps pods. You shouldn't need to
     # change this, but if you want to you can find more information here:
     # <https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/>
@@ -342,9 +359,11 @@ services:
         port: 4002
         scheme: HTTP
       # @ignore
-      failureThreshold: 3
+      failureThreshold: 5
       # @ignore
       periodSeconds: 5
+      # @ignore
+      timeoutSeconds: 5
     autoscaling:
       # -- Whether to enable horizontal pod autoscaling for the apps service.
       enabled: false
@@ -439,7 +458,9 @@ services:
       # @ignore
       periodSeconds: 3
       # @ignore
-      failureThreshold: 1
+      failureThreshold: 3
+      # @ignore
+      timeoutSeconds: 5
     # -- Liveness probe configuration for automation worker pods. You shouldn't
     # need to change this, but if you want to you can find more information
     # here:
@@ -452,9 +473,11 @@ services:
         port: 4002
         scheme: HTTP
       # @ignore
-      failureThreshold: 3
+      failureThreshold: 5
       # @ignore
       periodSeconds: 30
+      # @ignore
+      timeoutSeconds: 5
     autoscaling:
       # -- Whether to enable horizontal pod autoscaling for the apps service.
       enabled: false
@@ -550,6 +573,8 @@ services:
       periodSeconds: 5
       # @ignore
       failureThreshold: 3
+      # @ignore
+      timeoutSeconds: 5
     # -- Liveness probe configuration for worker pods. You shouldn't need to
     # change this, but if you want to you can find more information here:
     # <https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/>
@@ -561,9 +586,11 @@ services:
         port: 4003
         scheme: HTTP
       # @ignore
-      failureThreshold: 3
+      failureThreshold: 5
       # @ignore
       periodSeconds: 5
+      # @ignore
+      timeoutSeconds: 5
     autoscaling:
       # -- Whether to enable horizontal pod autoscaling for the worker service.
       enabled: false

charts/budibase/values.yaml

@@ -1,6 +1,6 @@
 {
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
-  "version": "3.39.21",
+  "version": "3.39.22",
   "npmClient": "yarn",
   "concurrency": 20,
   "command": {

lerna.json

@@ -77,6 +77,7 @@
   }
   .spectrum-Datepicker {
     width: 100%;
+    min-width: 104px;
     overflow: hidden;
   }
   .spectrum-Datepicker .spectrum-Textfield {

packages/bbui/src/Form/Core/DatePicker/DateInput.svelte

@@ -1,10 +1,12 @@
 <script>
   export let value
-  export let min
-  export let max
+  export let min = undefined
+  export let max = undefined
   export let hideArrows = false
-  export let width
+  export let width = undefined
   export let type = "number"
+  export let disabled = false
+  export let readonly = false
 
   $: style = width ? `width:${width}px;` : ""
 
@@ -18,6 +20,8 @@
   {value}
   {min}
   {max}
+  {disabled}
+  {readonly}
   on:click={selectAll}
   on:change
   on:input