chore: large file test

Author: bobbyg603

BugSplatDotNetStandard.Test/Api/CrashPostClient.cs

@@ -15,6 +15,8 @@
 using System.Net.Http;
 using System.Net;
 using System.IO.Compression;
+using System.Security.Cryptography;
+using System.Text.RegularExpressions;
 
 namespace Tests
 {
@@ -116,6 +118,25 @@ public async Task CrashPostClient_PostMinidump_ShouldReturn200()
             Assert.AreEqual(HttpStatusCode.OK, postResult.StatusCode);
         }
 
+        [Test]
+        public void CrashPostClient_PostMinidump_Returns400IfFileIsTooBig()
+        {
+            var bugsplat = new BugSplat(database, application, version);
+            var sut = new CrashPostClient(HttpClientFactory.Default, S3ClientFactory.Default);
+            var largeFile = CreateLargeTempFile(1000 * 1024 * 1024); // 1 GB
+
+            Assert.ThrowsAsync<Exception>(async () =>
+            {
+                await sut.PostMinidump(
+                    database,
+                    application,
+                    version,
+                    largeFile,
+                    MinidumpPostOptions.Create(bugsplat)
+                );
+            }, "Failed to parse symbol upload url: crash post size limit exceeded");
+        }
+
         [Test]
         public void CrashPostClient_PostException_ShouldNotThrowIfAttachmentLocked()
         {
@@ -192,7 +213,7 @@ public async Task CrashPostClient_PostCrashFile_PostCrashAndMetadata()
                 stackTrace,
                 ExceptionPostOptions.Create(bugsplat)
             );
-            
+
             var postResponseContent = JObject.Parse(postResult.Content.ReadAsStringAsync().Result);
             var id = postResponseContent["crashId"].Value<int>();
             var crashDetails = await crashDetailsClient.GetCrashDetails(database, id);
@@ -277,5 +298,36 @@ private Mock<HttpMessageHandler> CreateMockHttpClientForExceptionPost(string cra
 
             return handlerMock;
         }
+
+        private static FileInfo CreateLargeTempFile(long sizeInBytes, string fileNamePrefix = "LargeTestFile")
+        {
+            if (sizeInBytes < 0)
+        {
+            throw new ArgumentException("Size cannot be negative", nameof(sizeInBytes));
+        }
+
+        string tempFilePath = Path.Combine(Path.GetTempPath(), $"{fileNamePrefix}_{Guid.NewGuid()}.tmp");
+        const int bufferSize = 81920;
+        byte[] buffer = new byte[bufferSize];
+
+        using (var fileStream = new FileStream(tempFilePath, FileMode.Create, FileAccess.Write, FileShare.None, bufferSize))
+        {
+            fileStream.SetLength(sizeInBytes);
+
+            long bytesWritten = 0;
+            using (var rng = RandomNumberGenerator.Create())
+            {
+                while (bytesWritten < sizeInBytes)
+                {
+                    int bytesToWrite = (int)Math.Min(bufferSize, sizeInBytes - bytesWritten);
+                    rng.GetBytes(buffer, 0, bytesToWrite);
+                    fileStream.Write(buffer, 0, bytesToWrite);
+                    bytesWritten += bytesToWrite;
+                }
+            }
+        }
+
+        return new FileInfo(tempFilePath);
+        }
     }
 }

BugSplatDotNetStandard/Api/CrashPostClient.cs

@@ -142,7 +142,6 @@ public async Task<HttpResponseMessage> PostCrashFile(
             var zipFile = ZipUtils.CreateZipFile(zipFileName, files);
             try
             {
-
                 using (
                     var crashUploadResponse = await GetCrashUploadUrl(
                         database,
@@ -287,19 +286,23 @@ private string GetETagFromResponseHeaders(HttpHeaders headers)
 
         private async Task<Uri> GetPresignedUrlFromResponse(HttpResponseMessage response)
         {
-            try
-            {
-                var json = await response.Content.ReadAsStringAsync();
+            var json = await response.Content.ReadAsStringAsync();
 
-                var jsonObj = new JsonObject(json);
-                var url = jsonObj.GetValue("url");
+            var jsonObj = new JsonObject(json);
+            var url = jsonObj.TryGetValue("url");
+            var message = jsonObj.TryGetValue("message");
 
-                return new Uri(url);
+            if (string.IsNullOrEmpty(url) && !string.IsNullOrEmpty(message))
+            {
+                throw new Exception($"Failed to parse symbol upload url: {message}");
             }
-            catch (Exception ex)
+
+            if (string.IsNullOrEmpty(url))
             {
-                throw new Exception("Failed to parse crash upload url", ex);
+                throw new Exception("Failed to parse symbol upload url");
             }
+
+            return new Uri(url);
         }
     }
 }

BugSplatDotNetStandard/Http/JsonObject.cs

@@ -20,7 +20,7 @@ public JsonObject(string json)
         {
             this.json = json;
         }
-        
+
         public string GetValue(params string[] path)
         {
             var jsonBytes = Encoding.UTF8.GetBytes(json);
@@ -30,6 +30,18 @@ public string GetValue(params string[] path)
             var key = string.Join("/", path);
             return root.XPathSelectElement($"//{key}").Value;
         }
+        
+        public string TryGetValue(params string[] path)
+        {
+            try
+            {
+                return GetValue(path);
+            }
+            catch
+            {
+                return null;
+            }
+        }
     }
 
     public static class JsonSerializer