Apply suggestions from code review

bobbyg603 · Copilot · web-flow · commit 77ef4a5007d7 · 2026-03-20T11:06:30.000-04:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/BugSplatDotNetStandard/Api/CrashPostClient.cs b/BugSplatDotNetStandard/Api/CrashPostClient.cs
@@ -101,7 +101,7 @@ public async Task<HttpResponseMessage> PostFeedback(
             FeedbackPostOptions overridePostOptions = null
         )
         {
-            var description = overridePostOptions?.Description ?? defaultPostOptions?.Description ?? string.Empty;
+            var description = GetStringValueOrDefault(overridePostOptions?.Description, defaultPostOptions?.Description);
             var feedbackJson = JsonSerializer.Serialize(new Dictionary<string, string>
             {
                 { "title", title },
diff --git a/BugSplatDotNetStandard/BugSplat.cs b/BugSplatDotNetStandard/BugSplat.cs
@@ -299,10 +299,7 @@ public async Task<HttpResponseMessage> PostFeedback(string title, string descrip
                 using (var crashPostClient = new CrashPostClient(HttpClientFactory.Default, S3ClientFactory.Default))
                 {
                     var defaultOptions = FeedbackPostOptions.Create(this);
-                    if (!string.IsNullOrEmpty(description))
-                    {
-                        defaultOptions.Description = description;
-                    }
+                    defaultOptions.Description = description;
                     return await crashPostClient.PostFeedback(
                         Database,
                         Application,
diff --git a/BugSplatDotNetStandard/BugSplatPostOptions.cs b/BugSplatDotNetStandard/BugSplatPostOptions.cs
@@ -73,7 +73,8 @@ public static XmlPostOptions Create(IXmlPostOptions options)
 
     public class FeedbackPostOptions : BugSplatPostOptions
     {
-        public override int CrashTypeId { get => 36; }
+        private const int FeedbackCrashTypeId = 36;
+        public override int CrashTypeId { get => FeedbackCrashTypeId; }
         public static FeedbackPostOptions Create(IBugSplatPostOptions options)
         {
             return new FeedbackPostOptions

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public async Task<HttpResponseMessage> PostFeedback(`
`101`	`101`	`FeedbackPostOptions overridePostOptions = null`
`102`	`102`	`)`
`103`	`103`	`{`
`104`		`- var description = overridePostOptions?.Description ?? defaultPostOptions?.Description ?? string.Empty;`
	`104`	`+ var description = GetStringValueOrDefault(overridePostOptions?.Description, defaultPostOptions?.Description);`
`105`	`105`	`var feedbackJson = JsonSerializer.Serialize(new Dictionary<string, string>`
`106`	`106`	`{`
`107`	`107`	`{ "title", title },`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,8 @@ public static XmlPostOptions Create(IXmlPostOptions options)`
`73`	`73`
`74`	`74`	`public class FeedbackPostOptions : BugSplatPostOptions`
`75`	`75`	`{`
`76`		`- public override int CrashTypeId { get => 36; }`
	`76`	`+ private const int FeedbackCrashTypeId = 36;`
	`77`	`+ public override int CrashTypeId { get => FeedbackCrashTypeId; }`
`77`	`78`	`public static FeedbackPostOptions Create(IBugSplatPostOptions options)`
`78`	`79`	`{`
`79`	`80`	`return new FeedbackPostOptions`