Commit d7afcb1
feat: surface 429s as typed BugSplatRateLimitError (#168)
* feat: surface 429s as typed BugSplatRateLimitError
Rate-limited (HTTP 429) responses were thrown as a generic Error with a
"too many requests" message, leaving consumers to match on the message
string to detect them.
Add a BugSplatRateLimitError (isRateLimitError marker + status) and throw
it from the three presigned-URL sites (symbols/versions getPresignedUrl,
crash-post getCrashUploadUrl) so consumers can detect rate limiting by
type. Exported via the common/client barrel.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test: cover 429 in crash-post-client; drop es5 trailing comma
Addresses Copilot review feedback on #168:
- Remove trailing comma after the BugSplatRateLimitError `status`
constructor param (incompatible with Prettier `trailingComma: es5`).
- Add a spec asserting CrashPostClient throws BugSplatRateLimitError
with status 429 when getCrashUploadUrl returns 429.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ci: bump actions to v6 and Node 24 to clear node20 deprecation
- actions/checkout@main -> @v6, actions/setup-node@v4 -> @v6 (both now
run on the Node 24 runtime, clearing the node20 deprecation warning).
- node-version 22.x -> 24.x.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore: drop husky/commitlint for CI-based PR title linting
Husky's hook bootstrap is deprecated (fails in v10), and its commit-msg
hook only linted individual branch commits that get squashed away on
merge. Since PRs squash-merge with the PR title as the commit subject,
that title is what semantic-release parses for version bumps.
- Remove husky (dep, `prepare` script, .husky/, core.hooksPath).
- Remove @commitlint/cli, @commitlint/config-conventional, .commitlintrc.js
(only ever invoked by the husky commit-msg hook).
- Add a PR Title workflow using amannn/action-semantic-pull-request to
validate the PR title against Conventional Commits.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent a732426 commit d7afcb1
18 files changed
Lines changed: 110 additions & 907 deletions
File tree
- .github/workflows
- .husky
- src
- common/client
- oauth-client-credentials-api-client
- post
- symbols/symbols-api-client
- versions/versions-api-client
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
This file was deleted.
This file was deleted.
0 commit comments