Skip to content

Commit d7afcb1

Browse files
bobbyg603claude
andauthored
feat: surface 429s as typed BugSplatRateLimitError (#168)
* feat: surface 429s as typed BugSplatRateLimitError Rate-limited (HTTP 429) responses were thrown as a generic Error with a "too many requests" message, leaving consumers to match on the message string to detect them. Add a BugSplatRateLimitError (isRateLimitError marker + status) and throw it from the three presigned-URL sites (symbols/versions getPresignedUrl, crash-post getCrashUploadUrl) so consumers can detect rate limiting by type. Exported via the common/client barrel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: cover 429 in crash-post-client; drop es5 trailing comma Addresses Copilot review feedback on #168: - Remove trailing comma after the BugSplatRateLimitError `status` constructor param (incompatible with Prettier `trailingComma: es5`). - Add a spec asserting CrashPostClient throws BugSplatRateLimitError with status 429 when getCrashUploadUrl returns 429. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: bump actions to v6 and Node 24 to clear node20 deprecation - actions/checkout@main -> @v6, actions/setup-node@v4 -> @v6 (both now run on the Node 24 runtime, clearing the node20 deprecation warning). - node-version 22.x -> 24.x. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: drop husky/commitlint for CI-based PR title linting Husky's hook bootstrap is deprecated (fails in v10), and its commit-msg hook only linted individual branch commits that get squashed away on merge. Since PRs squash-merge with the PR title as the commit subject, that title is what semantic-release parses for version bumps. - Remove husky (dep, `prepare` script, .husky/, core.hooksPath). - Remove @commitlint/cli, @commitlint/config-conventional, .commitlintrc.js (only ever invoked by the husky commit-msg hook). - Add a PR Title workflow using amannn/action-semantic-pull-request to validate the PR title against Conventional Commits. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a732426 commit d7afcb1

18 files changed

Lines changed: 110 additions & 907 deletions

File tree

β€Ž.commitlintrc.jsβ€Ž

Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: PR Title
2+
3+
on:
4+
pull_request:
5+
types:
6+
- opened
7+
- edited
8+
- synchronize
9+
branches:
10+
- main
11+
12+
permissions:
13+
pull-requests: read
14+
15+
jobs:
16+
lint:
17+
runs-on: ubuntu-latest
18+
19+
steps:
20+
# The PR title becomes the squash commit subject that semantic-release
21+
# parses, so validate it follows Conventional Commits.
22+
- uses: amannn/action-semantic-pull-request@v6
23+
env:
24+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

β€Ž.github/workflows/release.ymlβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ jobs:
1010
runs-on: ubuntu-latest
1111

1212
steps:
13-
- uses: actions/checkout@main
13+
- uses: actions/checkout@v6
1414
with:
1515
persist-credentials: false
16-
17-
- uses: actions/setup-node@v4
16+
17+
- uses: actions/setup-node@v6
1818
with:
19-
node-version: "22.x"
19+
node-version: "24.x"
2020

2121
- name: Install
2222
run: npm install

β€Ž.github/workflows/test.ymlβ€Ž

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ jobs:
1010
runs-on: ubuntu-latest
1111

1212
steps:
13-
- uses: actions/checkout@main
13+
- uses: actions/checkout@v6
1414
with:
1515
persist-credentials: false
16-
17-
# Use latest Node.js 22 LTS
18-
- uses: actions/setup-node@v4
16+
17+
# Use latest Node.js 24 LTS
18+
- uses: actions/setup-node@v6
1919
with:
20-
node-version: "22.x"
20+
node-version: "24.x"
2121

2222
- name: Install
2323
run: npm install

β€Ž.husky/commit-msgβ€Ž

Lines changed: 0 additions & 4 deletions
This file was deleted.

β€Ž.husky/pre-commitβ€Ž

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
Β (0)