WalletConnect - Pending TODOs and known issues

[Pabl0cks]

Creating this to continue iterating on WalletConnect integration. Moving pending TODOs and issues from #46.

We can document new issues here too, and iterate with different PRs until is polished.

Features

• Save session information on LocalStorage to allow it to keep it working after a reload
• Maybe add a setting to auto-confirm transactions and signing
• It would be nice to add more info to the WalletConnect drawer, when you are "Connecting to Dapp" and when you're checking "Connected Dapp"
• In the future it may be nice to connect to more than 1 dapp at the same time. When everything is stable with 1 dapp.

Visual improvements

• We could move the transaction confirm modal and switch network alerts to a bottom drawer with nice format.

Issues

• When I disconnect from the dapp, and connect again, i keep getting "Wrong network" message. It also happens if I connect to a different Challenge, for example:
  • Connect to Chal 0, disconnect.
  • Connect to Chal 5, get "Wrong network" message > Change network to Sepolia in dapp > Disconnect
  • Connect to Chal 0, get the "Wrong network" message again.
• If you close the WC modal in the dapp (the one that lets you copy the code), it says "Connected" when you click "Connect Dapp" in the burner, but it doesn't really connect.
• When trying to performa swap in Uniswap on a different network than the burnerwallet network, it shows the confirm to change the network on burner several times.
• [Can't reproduce] This happens to me the first time I use the WC feature after opening the browser, with Firefox.
  I open Challenge 0 and connect (OK). Then try to fire a Mint tx, but it says "Cannot access account". If I disconnect and connect again, it works fine, but if I close Firefox, and connect again, it says "Cannot access account" again.

[damianmarti]

@Pabl0cks An update on the pending issues.

When I disconnect from the dapp, and connect again, i keep getting "Wrong network" message. It also happens if I connect to a different Challenge, for example:
Connect to Chal 0, disconnect.
Connect to Chal 5, get "Wrong network" message > Change network to Sepolia in dapp > Disconnect
Connect to Chal 0, get the "Wrong network" message again.

Not fixed yet, but I think it's related to a change network event, trying to have it fixed.

If you close the WC modal in the dapp (the one that lets you copy the code), it says "Connected" when you click "Connect Dapp" in the burner, but it doesn't really connect.

Not fixed yet too, but I saw that Metamask when scanning the official WalletConnect modal has the same behavior (tested on Chal 0 and Uniswap), so maybe it's something related to the WalletConnect web3modal...

[Pabl0cks]

Thanks for the update Damu!

Regarding the change network event, while testing #68 I found that the multiple confirm of "Change network to.." was happening when trying to perform an action in Uniswap / Blur.

Will add it to the list just to make sure to verify when we fix the network issues.

[Pabl0cks]

Regarding the change network event, while testing #68 I found that the multiple confirm of "Change network to.." was happening when trying to perform an action in Uniswap / Blur.

Will add it to the list just to make sure to verify when we fix the network issues.

Closed this sub-task, it is working now with #70 and #71 changes