Skip to content

Commit 437e663

Browse files
author
Jonathan Visser
committed
Fix linting issues
1 parent f00e9df commit 437e663

3 files changed

Lines changed: 20 additions & 29 deletions

File tree

nginx_config_reloader/__init__.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
import sys
1313
import threading
1414
import time
15-
from typing import Optional
1615
from pathlib import Path
16+
from typing import Optional
1717

18-
from watchdog.observers import Observer
19-
from watchdog.events import FileSystemEventHandler
2018
from dasbus.loop import EventLoop
2119
from dasbus.signal import Signal
20+
from watchdog.events import FileSystemEventHandler
21+
from watchdog.observers import Observer
2222

2323
from nginx_config_reloader.copy_files import safe_copy_files
2424
from nginx_config_reloader.dbus.common import NGINX_CONFIG_RELOADER, SYSTEM_BUS
@@ -105,8 +105,10 @@ def on_modified(self, event):
105105

106106
def on_any_event(self, event):
107107
"""Triggered by inotify when watched dir is moved or deleted"""
108-
if event.is_directory and event.event_type in ['moved', 'deleted']:
109-
self.logger.warning(f"Directory {event.src_path} has been {event.event_type}.")
108+
if event.is_directory and event.event_type in ["moved", "deleted"]:
109+
self.logger.warning(
110+
f"Directory {event.src_path} has been {event.event_type}."
111+
)
110112
raise ListenTargetTerminated
111113

112114
def handle_event(self, event):
@@ -117,13 +119,15 @@ def handle_event(self, event):
117119
or file_path.name.endswith("~")
118120
):
119121
return
120-
121-
if (event.is_directory):
122+
123+
if event.is_directory:
122124
return
123-
125+
124126
basename = os.path.basename(event.src_path)
125127
if not any(fnmatch.fnmatch(basename, pat) for pat in WATCH_IGNORE_FILES):
126-
self.logger.debug(f"{event.event_type.upper()} detected on {event.src_path}")
128+
self.logger.debug(
129+
f"{event.event_type.upper()} detected on {event.src_path}"
130+
)
127131
self.dirty = True
128132
# Additional handling if necessary
129133

@@ -329,10 +333,7 @@ def reload(self, send_signal=True):
329333
def start_observer(self):
330334
self.observer = Observer()
331335
self.observer.schedule(
332-
self,
333-
self.dir_to_watch,
334-
recursive=True,
335-
follow_symlink=True
336+
self, self.dir_to_watch, recursive=True, follow_symlink=True
336337
)
337338
self.observer.start()
338339

@@ -341,6 +342,7 @@ def stop_observer(self):
341342
self.observer.join()
342343
sys.exit()
343344

345+
344346
class ListenTargetTerminated(BaseException):
345347
pass
346348

@@ -411,7 +413,6 @@ def wait_loop(
411413
)
412414
time.sleep(5)
413415

414-
415416
try:
416417
logger.info(f"Listening for changes to {dir_to_watch}")
417418
nginx_config_changed_handler.start_observer()
@@ -425,7 +426,6 @@ def wait_loop(
425426
except KeyboardInterrupt:
426427
logger.info("Shutting down observer.")
427428
nginx_config_changed_handler.stop_observer()
428-
429429

430430

431431
def as_unprivileged_user():

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ black==23.1.0
99
pre-commit==2.21.0
1010
pygobject
1111
pygobject-stubs
12-
dasbus==1.7
12+
dasbus==1.7

tests/test_watchdog_callbacks.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,7 @@
44
from tempfile import NamedTemporaryFile, mkdtemp
55

66
import mock
7-
from watchdog.events import (
8-
DirCreatedEvent,
9-
DirDeletedEvent,
10-
DirMovedEvent,
11-
FileCreatedEvent,
12-
FileDeletedEvent,
13-
FileModifiedEvent,
14-
FileMovedEvent,
15-
)
7+
from watchdog.events import DirCreatedEvent, FileDeletedEvent, FileMovedEvent
168

179
import nginx_config_reloader
1810

@@ -50,9 +42,7 @@ def test_that_handle_event_is_called_when_a_file_is_removed(self):
5042

5143
def test_that_handle_event_is_called_when_a_file_is_moved_in(self):
5244
with NamedTemporaryFile(delete=False) as f:
53-
event = FileMovedEvent(
54-
f.name, os.path.join(self.dir, "newfile")
55-
)
45+
event = FileMovedEvent(f.name, os.path.join(self.dir, "newfile"))
5646
self.handler.on_moved(event)
5747

5848
self.assertEqual(len(self.handle_event.mock_calls), 1)
@@ -78,6 +68,7 @@ def test_that_handle_event_is_called_when_a_file_is_renamed(self):
7868

7969
self.assertGreaterEqual(len(self.handle_event.mock_calls), 1)
8070

71+
8172
class TestWatchdogRecursiveCallbacks(TestWatchdogCallbacks):
8273
# Run all callback tests on a subdir
8374
def setUp(self):
@@ -95,4 +86,4 @@ def setUp(self):
9586
self.handler.observer = self.observer
9687

9788
def tearDown(self):
98-
shutil.rmtree(self.rootdir, ignore_errors=True)
89+
shutil.rmtree(self.rootdir, ignore_errors=True)

0 commit comments

Comments
 (0)