Only half of Entities holding Relation to a Target Entity have their Component Removed on Despawn(target)

[thygrrr]

I came across a somewhat serious bug in Archetypes.cs while working on my fork.

This issue comes from the forward-iteration of the table while it has elements being removed from it. This skips every other Entity.

foreach (var tableWithType in tablesWithType)
{
    for (var i = 0; i < tableWithType.Count; i++)
    {
        RemoveComponent(type, tableWithType.Identities[i]);
    }
}

[thygrrr]

naive fix:

foreach (var tableWithType in tablesWithType)
{
    for (var i = tableWithType.Count-1; i >= 0; i--)
    {
        RemoveComponent(type, tableWithType.Identities[i]);
    }
}