testing and linting issues

Author: C00ldudeNoonan

macro_agents/src/macro_agents/defs/agents/backtest_optimizer.py

@@ -904,7 +904,7 @@ def auto_promote_best_models_to_production(
             continue
 
         try:
-            model_data = gcs.download_model(
+            _ = gcs.download_model(
                 module_name=module_name,
                 version=version,
                 context=context,

macro_agents/src/macro_agents/defs/resources/gcs.py

@@ -48,14 +48,18 @@ def setup_for_execution(self, context) -> None:
             # It's a JSON string, parse it and use from_service_account_info
             try:
                 creds_info = json.loads(creds_path)
-                credentials = service_account.Credentials.from_service_account_info(creds_info)
+                credentials = service_account.Credentials.from_service_account_info(
+                    creds_info
+                )
             except json.JSONDecodeError as e:
                 raise ValueError(
                     f"Failed to parse service account JSON from GOOGLE_APPLICATION_CREDENTIALS: {e}"
                 )
         elif os.path.exists(creds_path):
             # It's a file path, use from_service_account_file
-            credentials = service_account.Credentials.from_service_account_file(creds_path)
+            credentials = service_account.Credentials.from_service_account_file(
+                creds_path
+            )
         else:
             raise FileNotFoundError(
                 f"Credentials not found. Expected either a valid file path or JSON string, got: {creds_path[:100]}..."

macro_agents/tests/test_dspy_modules.py

@@ -64,12 +64,14 @@ def test_module_forward_with_default_personality(self):
         result = module.forward(
             economic_data="test economic data",
             commodity_data="test commodity data",
+            financial_conditions_index="test financial conditions",
         )
 
         assert result.analysis == "Test analysis output"
         module.analyze_state.assert_called_once_with(
             economic_data="test economic data",
             commodity_data="test commodity data",
+            financial_conditions_index="test financial conditions",
             personality="neutral",
         )
 
@@ -84,13 +86,15 @@ def test_module_forward_with_override_personality(self):
         result = module.forward(
             economic_data="test economic data",
             commodity_data="test commodity data",
+            financial_conditions_index="test financial conditions",
             personality="bullish",
         )
 
         assert result.analysis == "Test analysis output"
         module.analyze_state.assert_called_once_with(
             economic_data="test economic data",
             commodity_data="test commodity data",
+            financial_conditions_index="test financial conditions",
             personality="bullish",
         )
 
@@ -105,6 +109,7 @@ def test_module_forward_with_empty_data(self):
         result = module.forward(
             economic_data="",
             commodity_data="",
+            financial_conditions_index="",
         )
 
         assert result.analysis == "Analysis with empty data"
@@ -350,12 +355,14 @@ def test_personality_override_priority(self):
         module.forward(
             economic_data="test",
             commodity_data="test",
+            financial_conditions_index="test financial conditions",
             personality="bullish",
         )
 
         module.analyze_state.assert_called_once_with(
             economic_data="test",
             commodity_data="test",
+            financial_conditions_index="test financial conditions",
             personality="bullish",
         )
 
@@ -374,6 +381,7 @@ def test_economy_state_module_with_mock_lm(self):
         result = module.forward(
             economic_data="GDP,100.0,0.01,0.02,0.03",
             commodity_data="Oil,50.0,0.05",
+            financial_conditions_index="FCI: 0.5",
         )
 
         assert result.analysis == "Comprehensive economic analysis"