Skip to content

Commit 4eefaa8

Browse files
Fixed the tests to check the entire dataframe rather than specific cells
1 parent 78f3e6c commit 4eefaa8

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

process_report/tests/unit/processors/test_add_institution_processor.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66

77

88
class TestAddInstitutionProcessor(TestCase):
9-
def _get_test_data(self, pi_names, projects=None):
10-
if projects is None:
11-
projects = [f"Project{i}" for i in range(len(pi_names))]
9+
def _get_test_data(self, pi_names, projects=None, institutions=None):
10+
if institutions is None:
11+
institutions = ["" for i in pi_names]
1212
return pandas.DataFrame(
1313
{
1414
"Manager (PI)": pi_names,
1515
"Project - Allocation": projects,
16-
"Institution": ["" for _ in pi_names],
16+
"Institution": institutions,
1717
}
1818
)
1919

@@ -35,8 +35,12 @@ def test_add_institution(self, mock_load_institute_list):
3535
processor = test_utils.new_add_institution_processor(data=test_data)
3636
processor.process()
3737
output = processor.data
38-
assert output.loc[0, "Institution"] == "Boston University"
39-
assert output.loc[1, "Institution"] == "MIT"
38+
answer_data = self._get_test_data(
39+
pi_names=["pi1@bu.edu", "pi2@mit.edu"],
40+
projects=["ProjectA", "ProjectB"],
41+
institutions=["Boston University", "MIT"],
42+
)
43+
assert output.equals(answer_data)
4044

4145
@mock.patch("process_report.util.load_institute_list")
4246
def test_add_institution_missing_pi(self, mock_load_institute_list):

0 commit comments

Comments
 (0)