Update get_functions.py script now it raises exception on duplication (#78)

Author: CCXLV

crates/fluxqueue-worker/scripts/get_functions.py

@@ -12,6 +12,9 @@ def list_functions(module_path: str, queue: str):
             continue
 
         if inspect.isfunction(obj) or (inspect.isbuiltin(obj) and task_name):
+            if funcs.get(task_name):
+                raise ValueError(f"Task name '{task_name}' is duplicated")
+
             original_func = getattr(obj, "__wrapped__", obj)
             funcs[task_name] = original_func
     return funcs

crates/fluxqueue-worker/src/task.rs

@@ -14,7 +14,6 @@ impl TaskRegistry {
         }
     }
 
-    // TODO: Add task name duplication error
     pub fn insert(&self, name: String, func: Py<PyAny>) -> Result<()> {
         let mut tasks = self.tasks.write().map_err(|_| {
             anyhow::anyhow!("Internal Error: Task registry lock poisoned (a thread panicked)")

crates/fluxqueue-worker/src/worker.rs

@@ -340,9 +340,9 @@ fn get_task_functions(module_path: &str, queue_name: &str) -> Result<Vec<(String
 
         let py_funcs: Bound<'_, PyDict> = module
             .getattr("list_functions")
-            .map_err(|e| anyhow!("Failed to get 'list_functions': {}", e))?
+            .map_err(|e| anyhow!("Failed to get 'list_functions' script: {}", e))?
             .call1((real_module_path, queue_name))
-            .map_err(|e| anyhow!("Failed to execute 'list_functions' to get tasks: {}", e))?
+            .map_err(|e| anyhow!("Failed to get tasks: {}", e))?
             .cast_into::<PyDict>()
             .map_err(|_| anyhow!("Failed to cast result to a Python Dictionary"))?;