clang - keep temp files from overwriting each other

Author: jeremylt

.gitignore

@@ -52,7 +52,7 @@ doc/sphinx/build/
 doc/sphinx/source/examples/
 
 # Clang GPU temp files
-temp_*
+temp/*
 
 # Output files, videos, and compressed archives should not be added accidentally
 *.avi

Makefile

@@ -915,7 +915,7 @@ cln clean :
 	$(call quiet,MAKE) -C examples clean NEK5K_DIR="$(abspath $(NEK5K_DIR))"
 	$(call quiet,MAKE) -C python/tests clean
 	$(RM) benchmarks/*output.txt
-	$(RM) -f temp_*
+	$(RM) -rf temp
 
 distclean : clean
 	$(RM) -r doc/html doc/sphinx/build $(CONFIG)

backends/cuda/ceed-cuda-compile.cpp

@@ -15,6 +15,7 @@
 #include <nvrtc.h>
 #include <stdarg.h>
 #include <string.h>
+#include <sys/stat.h>
 #include <sys/types.h>
 
 #include <cstdlib>
@@ -54,7 +55,7 @@ static int CeedCallSystem_Core(Ceed ceed, const char *command, const char *messa
   }
   CeedDebug(ceed, "Command output:\n%s\n", output);
 
-  CeedCheck(pclose(output_stream) == 0, ceed, CEED_ERROR_BACKEND, "Failed to %s with error: %s", message, output);
+  CeedCheck(pclose(output_stream) == 0, ceed, CEED_ERROR_BACKEND, "Failed to %s with command: %s\nand error: %s", message, command, output);
   return CEED_ERROR_SUCCESS;
 }
 
@@ -154,8 +155,6 @@ static int CeedCompileCore_Cuda(Ceed ceed, const char *source, const bool throw_
   // Add string source argument provided in call
   code << source;
 
-  // Create Program
-
   // Compile kernel
   CeedDebug256(ceed, CEED_DEBUG_COLOR_SUCCESS, "---------- ATTEMPTING TO COMPILE JIT SOURCE ----------\n");
   CeedDebug(ceed, "Source:\n%s\n", code.str().c_str());
@@ -221,15 +220,30 @@ static int CeedCompileCore_Cuda(Ceed ceed, const char *source, const bool throw_
     CeedCallBackend(CeedFree(&ptx));
     return CEED_ERROR_SUCCESS;
   } else {
-    const char *full_filename = "temp_kernel_source.cu";
-    FILE       *file          = fopen(full_filename, "w");
+    const int build_id = rand();
 
-    CeedCheck(file, ceed, CEED_ERROR_BACKEND, "Failed to create file. Write access is required for cuda-clang\n");
-    fputs(code.str().c_str(), file);
-    fclose(file);
+    // Create temp dir if needed
+    {
+      DIR *dir = opendir("temp");
 
-    // Get rust crate directories
+      if (dir) {
+        closedir(dir);
+      } else {
+        mkdir("temp", 0777);
+        chmod("temp", 0777);
+      }
+    }
+    // Write code to temp file
+    {
+      std::string filename = std::string("temp/kernel_") + std::to_string(build_id) + std::string("_0_source.cu");
+      FILE       *file     = fopen(filename.c_str(), "w");
+
+      CeedCheck(file, ceed, CEED_ERROR_BACKEND, "Failed to create file. Write access is required for cuda-clang");
+      fputs(code.str().c_str(), file);
+      fclose(file);
+    }
 
+    // Get rust crate directories
     const char **rust_source_dirs     = nullptr;
     int          num_rust_source_dirs = 0;
 
@@ -265,14 +279,17 @@ static int CeedCompileCore_Cuda(Ceed ceed, const char *source, const bool throw_
 
     // Compile wrapper kernel
     command = "clang++ -flto=thin --cuda-gpu-arch=sm_" + std::to_string(prop.major) + std::to_string(prop.minor) +
-              " --cuda-device-only -emit-llvm -S temp_kernel_source.cu -o temp_kernel.ll ";
+              " --cuda-device-only -emit-llvm -S temp/kernel_" + std::to_string(build_id) + "_0_source.cu -o temp/kernel_" +
+              std::to_string(build_id) + "_1_wrapped.ll";
     command += opts[4];
     CeedCallSystem(ceed, command.c_str(), "JiT kernel source");
 
     // the find command finds the rust-installed llvm-link tool and runs it
-    command = "$(find $(rustup run " + std::string(rust_toolchain) +
-              " rustc --print sysroot) -name llvm-link) temp_kernel.ll --ignore-non-bitcode --internalize --only-needed -S -o "
-              "temp_kernel_linked.ll  ";
+    command = "$(find $(rustup run " + std::string(rust_toolchain) + " rustc --print sysroot) -name llvm-link) temp/kernel_" +
+              std::to_string(build_id) +
+              "_1_wrapped.ll --ignore-non-bitcode --internalize --only-needed -S -o "
+              "temp/kernel_" +
+              std::to_string(build_id) + "_2_linked.ll";
 
     // Searches for .a files in rust directoy
     // Note: this is necessary because rust crate names may not match the folder they are in
@@ -298,18 +315,20 @@ static int CeedCompileCore_Cuda(Ceed ceed, const char *source, const bool throw_
     // Link, optimize, and compile final CUDA kernel
     // note that the find command is used to find the rust-installed llvm tool
     CeedCallSystem(ceed, command.c_str(), "link C and Rust source");
-    CeedCallSystem(ceed,
-                   ("$(find $(rustup run " + std::string(rust_toolchain) +
-                    " rustc --print sysroot) -name opt) --passes internalize,inline temp_kernel_linked.ll -o temp_kernel_opt.bc")
-                       .c_str(),
-                   "optimize linked C and Rust source");
+    CeedCallSystem(
+        ceed,
+        ("$(find $(rustup run " + std::string(rust_toolchain) + " rustc --print sysroot) -name opt) --passes internalize,inline temp/kernel_" +
+         std::to_string(build_id) + "_2_linked.ll -o temp/kernel_" + std::to_string(build_id) + "_3_opt.bc")
+            .c_str(),
+        "optimize linked C and Rust source");
     CeedCallSystem(ceed,
                    ("$(find $(rustup run " + std::string(rust_toolchain) + " rustc --print sysroot) -name llc) -O3 -mcpu=sm_" +
-                    std::to_string(prop.major) + std::to_string(prop.minor) + " temp_kernel_opt.bc -o temp_kernel_final.ptx")
+                    std::to_string(prop.major) + std::to_string(prop.minor) + " temp/kernel_" + std::to_string(build_id) +
+                    "_3_opt.bc -o temp/kernel_" + std::to_string(build_id) + "_4_final.ptx")
                        .c_str(),
                    "compile final CUDA kernel");
 
-    ifstream      ptxfile("temp_kernel_final.ptx");
+    ifstream      ptxfile("temp/kernel_" + std::to_string(build_id) + "_4_final.ptx");
     ostringstream sstr;
 
     sstr << ptxfile.rdbuf();

examples/ceed/.gitignore

@@ -1,2 +1,3 @@
 ex1-volume
 ex2-surface
+ex3-volume

examples/rust-qfunctions/.gitignore

@@ -1 +1,2 @@
-temp_*
+ex1-volume
+temp/*

examples/rust-qfunctions/Makefile

@@ -31,5 +31,5 @@ ex1-volume: ex1-volume.c
 
 clean:
 	rm -f *~ $(EXAMPLES)
-	rm -f temp_*
+	rm -rf temp/
 	rm -rf *.dSYM *.TVD.*breakpoints