SWE WIP: Fix a bug in advection QFunction

valeriabarra · valeriabarra · commit db149ba0e8b0 · 2020-09-22T20:30:06.000-06:00
Still need some debugging
diff --git a/examples/fluids/shallow-water/qfunctions/advection.h b/examples/fluids/shallow-water/qfunctions/advection.h
@@ -321,7 +321,7 @@ CEED_QFUNCTION(SWImplicit_Advection)(void *ctx, CeedInt Q,
        u_dot_grad_h += u[j] * dhdx_j;
      }
      CeedScalar strongConv = (h + H0) *div_u + u_dot_grad_h;
-     CeedScalar strongResid = qdot[4][i] + strongConv;
+     CeedScalar strongResid = qdot[2][i] + strongConv;
 
      v[2][i] = wdetJ * qdot[2][i]; // transient part (ALWAYS)
 

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ CEED_QFUNCTION(SWImplicit_Advection)(void *ctx, CeedInt Q,`
`321`	`321`	`u_dot_grad_h += u[j] * dhdx_j;`
`322`	`322`	`}`
`323`	`323`	`CeedScalar strongConv = (h + H0) *div_u + u_dot_grad_h;`
`324`		`- CeedScalar strongResid = qdot[4][i] + strongConv;`
	`324`	`+ CeedScalar strongResid = qdot[2][i] + strongConv;`
`325`	`325`
`326`	`326`	`v[2][i] = wdetJ * qdot[2][i]; // transient part (ALWAYS)`
`327`	`327`