Fix removing cycle relationship (#579)

Author: KWMORALE

mwdb/model/object.py

@@ -359,8 +359,9 @@ def remove_parent(self, parent, commit=True):
 
         try:
             # Remove inherited permissions from parent
-            for share in parent.shares:
-                self.uninherit_share(share)
+            if parent.id != self.id:
+                for share in parent.shares:
+                    self.uninherit_share(share)
             # Remove parent
             self.parents.remove(parent)
             db.session.flush()

tests/backend/test_relations.py

@@ -466,3 +466,23 @@ def test_removing_relations(admin_session):
         should_access=[Alice],
         should_not_access=[Bob],
     ).test()
+
+
+def test_remove_self_cycle_relation(admin_session):
+    testCase = RelationTestCase(admin_session)
+
+    Alice = testCase.new_user("Alice", capabilities=["removing_parents"])
+
+    SampleA = testCase.new_sample("SampleA")
+
+    SampleA.create(Alice)
+
+    SampleA.create(parent=SampleA)
+
+    a_shares = Alice.session.get_shares(SampleA.dhash)["shares"]
+
+    Alice.session.remove_parent(SampleA.dhash, SampleA.dhash)
+
+    a_shares_after_remove = Alice.session.get_shares(SampleA.dhash)["shares"]
+
+    assert a_shares == a_shares_after_remove