libnetconf2 REFACTOR unitialized variables

michalvasko · michalvasko · commit e2bfcd659612 · 2024-03-28T07:58:49.000+01:00
False positives.
diff --git a/src/session_server_ssh.c b/src/session_server_ssh.c
@@ -1094,7 +1094,7 @@ nc_server_ssh_create_ssh_pubkey(const char *base64, ssh_key *key)
 static int
 auth_pubkey_compare_key(ssh_key key, struct nc_auth_client *auth_client)
 {
-    uint16_t i, pubkey_count;
+    uint16_t i, pubkey_count = 0;
     int ret = 0;
     ssh_key new_key = NULL;
     struct nc_public_key *pubkeys = NULL;
diff --git a/tests/test_client_ssh.c b/tests/test_client_ssh.c
@@ -370,7 +370,7 @@ test_nc_client_ssh_adding_keypair(void **state)
 {
     (void)state;
     int ret;
-    const char *pubkey1, *pubkey2;
+    const char *pubkey1 = NULL, *pubkey2 = NULL;
 
     /* at the beginning keypair count should be 0 */
     ret = nc_client_ssh_get_keypair_count();

Original file line number	Diff line number	Diff line change
`@@ -1094,7 +1094,7 @@ nc_server_ssh_create_ssh_pubkey(const char base64, ssh_key key)`
`1094`	`1094`	`static int`
`1095`	`1095`	`auth_pubkey_compare_key(ssh_key key, struct nc_auth_client *auth_client)`
`1096`	`1096`	`{`
`1097`		`- uint16_t i, pubkey_count;`
	`1097`	`+ uint16_t i, pubkey_count = 0;`
`1098`	`1098`	`int ret = 0;`
`1099`	`1099`	`ssh_key new_key = NULL;`
`1100`	`1100`	`struct nc_public_key *pubkeys = NULL;`
Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ test_nc_client_ssh_adding_keypair(void **state)`
`370`	`370`	`{`
`371`	`371`	`(void)state;`
`372`	`372`	`int ret;`
`373`		`- const char pubkey1, pubkey2;`
	`373`	`+ const char pubkey1 = NULL, pubkey2 = NULL;`
`374`	`374`
`375`	`375`	`/* at the beginning keypair count should be 0 */`
`376`	`376`	`ret = nc_client_ssh_get_keypair_count();`