fix linter remarks

Signed-off-by: Paul Gannay <paul.gannay@cea.fr>

Author: PaulGannay

src/ddc/print.cpp

@@ -67,7 +67,7 @@ void print_dim_name(
 
 } // namespace detail
 
-PrinterOptions set_print_options(PrinterOptions const options)
+PrinterOptions set_print_options(PrinterOptions options)
 {
     ddc::detail::ChunkPrinter& printer = ddc::detail::ChunkPrinter::get_instance();
 

src/ddc/print.hpp

@@ -52,9 +52,13 @@ struct ChunkPrinter
 
     ChunkPrinter(ChunkPrinter&) = delete;
     ChunkPrinter(ChunkPrinter&&) = delete;
+    ChunkPrinter operator=(ChunkPrinter&&) = delete;
+    ChunkPrinter& operator=(ChunkPrinter& other) = delete;
+
+    ~ChunkPrinter() = default;
 
 private:
-    ChunkPrinter() {}
+    ChunkPrinter() = default;
 
     /**
      * Print the spaces needed to align value to os
@@ -342,7 +346,7 @@ void print_dim_name(std::ostream& os, DiscreteVector<Dims...> const& dd)
  * option is invalid if m_edgeitems >= (m_threshold / 2), in this case the
  * format isn't changed.
  */
-PrinterOptions set_print_options(PrinterOptions const options = PrinterOptions());
+PrinterOptions set_print_options(PrinterOptions options = PrinterOptions());
 
 /**
  * Return the currently used format options
@@ -434,7 +438,7 @@ std::ostream& print_full(
     ddc::detail::ChunkPrinter& printer = ddc::detail::ChunkPrinter::get_instance();
     std::scoped_lock const lock(printer.m_global_lock);
 
-    PrinterOptions old_options
+    const PrinterOptions old_options
             = set_print_options({.threshold = std::numeric_limits<size_t>::max(), .edgeitems = 1});
 
     print_type_info(os, chunk_span);

tests/print.cpp

@@ -226,7 +226,7 @@ void TestPrintFull()
 {
     // Very restrictive options
     ddc::set_print_options({.threshold = 3, .edgeitems = 1});
-    ddc::PrinterOptions options = ddc::get_print_options();
+    const ddc::PrinterOptions options = ddc::get_print_options();
 
     unsigned const dim0 = 6;
     unsigned const dim1 = 6;
@@ -391,7 +391,7 @@ template <typename ElementType>
 void TestPrintCheckCheckIncorrectOptions()
 {
     // Reset options
-    ddc::PrinterOptions defaultOptions = ddc::set_print_options();
+    const ddc::PrinterOptions defaultOptions = ddc::set_print_options();
     ddc::PrinterOptions newOptions;
 
     // Test obviously wrong options