Conversation
tretre91
left a comment
tretre91
left a comment
There was a problem hiding this comment.
Looks good to me. It's a little over the 1000 words limit (I count ~1420 words) but it doesn't feel that long to read, so I would try to submit it and see if the reviewers request to shorten it
tpadioleau
force-pushed
the
joss-paper
branch
2 times, most recently
from
7a859f5 to
19f426f
Compare
tpadioleau
force-pushed
the
joss-paper
branch
2 times, most recently
from
d3a9975 to
3b1a464
Compare
jbigot
left a comment
jbigot
left a comment
There was a problem hiding this comment.
Looks good!
I still think that it would help the reader to define the concepts a bit more formally before jumping into implementation details. This is however a choice, and given that choice, this is a very good presentation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 90.11% 90.03% -0.09%
==========================================
Files 55 55
Lines 2925 2851 -74
Branches 986 969 -17
==========================================
- Hits 2636 2567 -69
+ Misses 91 90 -1
+ Partials 198 194 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jbigot can I get an other review for the last 2 commits please ? |
jbigot
left a comment
jbigot
left a comment
There was a problem hiding this comment.
Your changes in the last 2 commits look great to me
EmilyBourne
left a comment
EmilyBourne
left a comment
There was a problem hiding this comment.
As per the JOSS docs:
The paper should be between 250-1000 words. Authors submitting papers significantly longer than 1000 words may be asked to reduce the length of their paper.
Beware, you are currently at ~1763 words
Co-authored-by: Julien Bigot <jbigot@users.noreply.github.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
* Fix typos false positive * Correct key
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
…or (#956) * Update references * Update authors and date * Update more citations --------- Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
* Update paper.md * Update paper.bib --------- Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
tpadioleau
force-pushed
the
joss-paper
branch
from
9fa08d1 to
113f78b
Compare
|
Closing as accepted and published https://joss.theoj.org/papers/10.21105/joss.09122 |
8 participants
Uh oh!
There was an error while loading. Please reload this page.