Commit 7be47bb
committed
Remove dead MSVC version fallbacks in CGAL_GeneratorSpecificSettings.cmake
Remove the dead elseif(MSVC14) through elseif(MSVC71) fallback chain.
These are unreachable because CGAL requires CMake >= 3.15, which always
defines MSVC_TOOLSET_VERSION for any MSVC build. Additionally, CGAL
requires C++17, which needs VS 2017+ at minimum.
Add an explicit elseif(MSVC) branch with AUTHOR_WARNING for the edge
case where MSVC is detected but MSVC_TOOLSET_VERSION is unexpectedly
empty, so it fails loudly instead of silently skipping toolset config.
The else() branch preserves the status message for non-MSVC compilers.1 parent b3cb16c commit 7be47bb
File tree
1 file changed
+5
-21
lines changed- Installation/cmake/modules
1 file changed
+5
-21
lines changedLines changed: 5 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
35 | 19 | | |
36 | 20 | | |
37 | 21 | | |
| |||
0 commit comments