Skip to content

Update the Three documentation #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 16, 2017
Merged

Update the Three documentation #2028

merged 13 commits into from
Jun 16, 2017

Conversation

maxGimeno
Copy link
Contributor

@maxGimeno maxGimeno commented Apr 6, 2017 •
edited
Loading

Summary of Changes

The reference manual has been rewritten in a way that is supposed to be more clear and useful.
New doc visible here.

Release Management

@maxGimeno maxGimeno force-pushed the Update_Three_doc-GF branch from 34401e9 to db1b3a7 Compare April 6, 2017 12:22
@lrineau
Copy link
Member

lrineau commented Apr 6, 2017

The Polyhedron_demo does not build: https://travis-ci.org/CGAL/cgal/jobs/219258495

@lrineau
Copy link
Member

lrineau commented Apr 7, 2017

The Travis compilation still fail. Does it build locally?

@lrineau lrineau added this to the 4.11-beta milestone May 10, 2017
@lrineau
Copy link
Member

lrineau commented May 30, 2017

This PR has conflicts with master.

@maxGimeno maxGimeno force-pushed the Update_Three_doc-GF branch from 1eb39a1 to 2e506fe Compare May 30, 2017 13:20
@lrineau
Copy link
Member

lrineau commented May 31, 2017

Travis build failure: https://travis-ci.org/CGAL/cgal/jobs/237514233

I actually does not understand the build failure. What failed was the build of the header file CGAL_ImageIO/include/CGAL/Image_3_impl.h, but that header does not seem modified by the PR!

@maxGimeno
Copy link
Contributor Author

I just restarted the job and this time it didn't fail.

@lrineau lrineau self-assigned this Jun 1, 2017
@lrineau
Copy link
Member

lrineau commented Jun 7, 2017

New warnings:

Scene.h:58:7: warning: 'erase' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:129:8: warning: 'postDraw' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:130:8: warning: 'paintEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:131:8: warning: 'paintGL' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:134:8: warning: 'mousePressEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:135:8: warning: 'wheelEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:137:8: warning: 'keyPressEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:139:8: warning: 'contextMenuEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:141:8: warning: 'keyReleaseEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:144:8: warning: 'resizeGL' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:43:8: warning: 'draw' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:45:8: warning: 'drawVisualHints' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:47:8: warning: 'fastDraw' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:48:8: warning: 'isExtensionFound' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:50:8: warning: 'initializeGL' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:52:8: warning: 'drawWithNames' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:57:8: warning: 'postSelection' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:59:8: warning: 'beginSelection' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:61:8: warning: 'endSelection' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:63:8: warning: 'setScene' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:65:8: warning: 'antiAliasing' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:67:8: warning: 'inFastDrawing' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:69:8: warning: 'inDrawWithNames' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Viewer.h:71:8: warning: 'attribBuffers' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

https://cgal.geometryfactory.com/CGAL/testsuite/results-4.11-Ic-34.shtml#Polyhedron_Demo

@lrineau lrineau added Previously tested rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Tested and removed Ready to be tested Under Testing Previously tested labels Jun 15, 2017
@lrineau lrineau merged commit 91de52e into CGAL:master Jun 16, 2017
lrineau added a commit that referenced this pull request Jun 16, 2017
@lrineau
Merge pull request #2028 from maxGimeno/Update_Three_doc-GF
86ecb6e 
Update the Three documentation
@lrineau lrineau added CGAL 3D demo Doc and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Jun 16, 2017
@lrineau lrineau deleted the Update_Three_doc-GF branch June 16, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
CGAL 3D demo Doc Tested
Projects
None yet
Milestone
4.11-beta
Development

Successfully merging this pull request may close these issues.

Polyhedron_demo : Update and fix the doc
2 participants
@maxGimeno @lrineau