Skip to content

Conversation

@afabri
Copy link
Member

@afabri afabri commented Feb 14, 2025

Summary of Changes

Add a tutorial for getting started with 2D Triangulations in an easier way than the User Manual.
This could as well become a section in the User Manual.

Link to the html page.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@afabri

This comment was marked as outdated.

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8739/v0/Manual/index.html

@MaelRL MaelRL added this to the 6.2-beta milestone Apr 16, 2025
@sloriot sloriot changed the base branch from master to main September 18, 2025 15:18
@sloriot
Copy link
Member

sloriot commented Sep 24, 2025

@afabri what is the status?

of the points in finite triangular faces.
Additionally, the triangulation generates infinite faces, which are incident to the edges of the convex hull
and which have as third vertex a single infinite vertex. When we draw the triangulation
we only draw finite vertices and faces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you mention that the points are not inserted in the order of the range?

A handle is a pointer to a vertex object, and no surprise when we write
`v->point()` into `std::cout` we will see `1 1` on the console.

Just like the standard containers, the triangulation provides iterators to enumerate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply mention ranges?

@afabri
Copy link
Member Author

afabri commented Jan 12, 2026

/force-build:v0

@github-actions
Copy link

There was an error while building the doc:

/home/runner/work/cgal/cgal/Triangulation_2/doc/Triangulation_2/Triangulation_2.txt:26: warning: unable to resolve reference to 'Section_2D_Triangulations_Constrained:' for \ref command

https://github.com/CGAL/cgal/actions/runs/20921859889

@afabri
Copy link
Member Author

afabri commented Jan 12, 2026

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8739/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Jan 12, 2026

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8739/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Jan 12, 2026

@albert-github can you help us to understand what is necessary for doxygen that it adds a section Examples in a reference manual page.

@sloriot
Copy link
Member

sloriot commented Jan 12, 2026

@albert-github can you help us to understand what is necessary for doxygen that it adds a section Examples in a reference manual page.

What do you mean?

@afabri
Copy link
Member Author

afabri commented Jan 12, 2026

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8739/v0/Manual/index.html

@albert-github
Copy link
Contributor

@afabri

I don't get the question either which example where should it be etc.
Maybe this will help a little: the examples section is in doxygen based on the \examples command, so when the command \example is given you will also see and example section, see e.g. the following quick example I made (I didn't compile it to see whether or not it is 100% valid code): example.tar.gz

with Delaunay triangulation with and without constraints.

\section Tutorial_Delaunay_2 Defining the Type of %Triangulation
<H1> Tutorial_Delaunay_2 Defining the Type of Triangulation</h1>
Copy link
Contributor

@albert-github albert-github Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section numbers are spevial to CGAL, the way it is re-implemented here looses the possibility to refer to a section and the possibility of the TOC .

@MaelRL
Copy link
Member

MaelRL commented Jan 17, 2026

@albert-github @sloriot

The question was "what does it take for the list of examples using this function to show up at the bottom of the documentation of a class or a function".

For example :

CGAL::Polygon_mesh_processing::repair_polygon_soup().

--> used in the example repair_polygon_soup_example.cpp, which is in PMP/examples.txt

but there is nothing at the bottom of the function's documentation, whereas we'd expect references to examples at the bottom of the function documentation:


image

But in fact it seems related to the fact that there is no link in the doc output:


image

and that seems to be related to the fact that we use a namespace alias:

namespace PMP = CGAL::Polygon_mesh_processing;

If I change the example and put "CGAL::Polygon_mesh_processing::repair_polygon_soup", then the link shows up:


image

and I get the example showing in the function doc:


image

So the questions are:

  • What can we do so links show up when using namespace aliases ?
  • Are there other conditions such that the example links do not appear at the bottom of functions, for example for class template member functions?
  • How does doxygen select which example to show in the list when there are many .cpp using that function? (CGAL::IO::read_polygon_mesh for example).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants