Skip to content

Conversation

@lrineau
Copy link
Member

@lrineau lrineau commented Nov 5, 2025

Summary of Changes

Followup to #9089. For the moment, this one is based on main.

Release Management

  • Affected package(s): CDT_3, STL_Extension
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

lrineau and others added 22 commits October 29, 2025 14:14
helped by Copilot
Add new bisect_failures template function to help identify minimal failing
test cases from complex input data. The utility uses a bisection-like approach
to iteratively simplify data and locate the smallest subset that causes failures.

Features:
- Handles multiple failure types: CGAL exceptions, std::exceptions, exit codes
- Automatic ratio adjustment (starts at 0.5, halves when no fault found)
- Saves intermediate states for debugging (current, bad, error, final_bad)
- Comprehensive test suite with 14 tests covering all combinations:
  * Edge cases (empty data, no failures)
  * Single element failures (each failure type independently)
  * Pair combinations (all 2-element permutations)
  * Triple combinations (all 3 failure types together)
  * Large datasets (up to 200 elements)

The test suite demonstrates complete combinatorial coverage of three
independent failure conditions and validates the algorithm's ability to
isolate minimal failing cases.

All tests pass in both Debug and Release configurations.
@afabri
Copy link
Member

afabri commented Nov 6, 2025

clang: error: unknown argument: '-fexperimental-library' in CGAL-6.2-Ic-35

@sloriot
Copy link
Member

sloriot commented Dec 26, 2025

Successfully tested in CGAL-6.2-Ic-70

Should it be back-ported to 6.1.x?

@github-actions github-actions bot removed the Tested label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

**detect again when the result of the conforming has self-intersections**

The regression was in the following commit:

> commit 5d1f330
> Author: Laurent Rineau <[email protected]>
> Date:   Thu Dec 4 11:14:00 2025 +0100
>
>     WIP: new way to construct the cavity

from the current PR (CGAL#9123).
@sloriot
Copy link
Member

sloriot commented Jan 13, 2026

@lrineau
Copy link
Member Author

lrineau commented Jan 15, 2026

ICE with MSVC 2017

https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-81/Constrained_triangulation_3/TestReport_Christo_MSVC2017-Release-64bits.gz

Is that the latest version of MSVC 19.16? The path to cl.exe is

C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe

with MSVC/14.16.27023/ in it, indication build 27023. But the detected compiler version is MSVC 19.16.27054.0 (build 27054). Which one it right? And how can we now if the build 27054 is the latest version?

@sloriot
Copy link
Member

sloriot commented Jan 15, 2026

ICE with MSVC 2017
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-81/Constrained_triangulation_3/TestReport_Christo_MSVC2017-Release-64bits.gz

Is that the latest version of MSVC 19.16? The path to cl.exe is

C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe

with MSVC/14.16.27023/ in it, indication build 27023. But the detected compiler version is MSVC 19.16.27054.0 (build 27054). Which one it right? And how can we now if the build 27054 is the latest version?

@soesau any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants