-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CDT_3: fix v2 #9123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CDT_3: fix v2 #9123
Conversation
helped by Copilot
Add new bisect_failures template function to help identify minimal failing test cases from complex input data. The utility uses a bisection-like approach to iteratively simplify data and locate the smallest subset that causes failures. Features: - Handles multiple failure types: CGAL exceptions, std::exceptions, exit codes - Automatic ratio adjustment (starts at 0.5, halves when no fault found) - Saves intermediate states for debugging (current, bad, error, final_bad) - Comprehensive test suite with 14 tests covering all combinations: * Edge cases (empty data, no failures) * Single element failures (each failure type independently) * Pair combinations (all 2-element permutations) * Triple combinations (all 3 failure types together) * Large datasets (up to 200 elements) The test suite demonstrates complete combinatorial coverage of three independent failure conditions and validates the algorithm's ability to isolate minimal failing cases. All tests pass in both Debug and Release configurations.
|
|
Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
Outdated
Show resolved
Hide resolved
|
Successfully tested in CGAL-6.2-Ic-70 Should it be back-ported to 6.1.x? |
|
This pull-request was previously marked with the label |
**detect again when the result of the conforming has self-intersections** The regression was in the following commit: > commit 5d1f330 > Author: Laurent Rineau <[email protected]> > Date: Thu Dec 4 11:14:00 2025 +0100 > > WIP: new way to construct the cavity from the current PR (CGAL#9123).
Is that the latest version of MSVC 19.16? The path to
with |
@soesau any idea? |
Summary of Changes
Followup to #9089. For the moment, this one is based on
main.Release Management