fix: accept empty values and buffers in comp-3 codec (#43)

* fix: accept empty values and buffers in the COMP-3 codec

* fix: accept empty values and buffers in the COMP-3 codec

* fix: accept invalid COMP-3 buffers

* fix: accept invalid COMP-3 buffers

* fix: init buffers with 0 instead of spaces

* fix: revert comp-3 alpha nibbles

Author: adrienaury

CHANGELOG.md

@@ -16,7 +16,7 @@ Types of changes
 
 ## [0.3.1]
 
-- `Fixed` accept null values and buffers in the COMP-3 codec.
+- `Fixed` accept empty values and buffers in the COMP-3 codec.
 
 ## [0.3.0]
 

internal/appli/command/fold.go

@@ -119,18 +119,13 @@ func (f *Fold) execUntilEOF(cfg config.Config, buffer api.Buffer, writer documen
 		}
 	}()
 
-	space, err := charsets.GetByteInCharset(f.charset, ' ')
-	if err != nil {
-		return fmt.Errorf("failed to get space in charset : %w", err)
-	}
-
 	sep, err := charsets.GetBytesInCharset(f.charset, cfg.Separator)
 	if err != nil {
 		return fmt.Errorf("failed to get separator in charset : %w", err)
 	}
 
 	for {
-		if err := buffer.Reset(space, cfg.Length, sep...); errors.Is(err, io.EOF) {
+		if err := buffer.Reset(0, cfg.Length, sep...); errors.Is(err, io.EOF) {
 			return nil
 		} else if err != nil {
 			return fmt.Errorf("failed to read next buffer : %w", err)

internal/appli/command/testdata/fold/13-comp3/stdin.fixed-width

@@ -1,3 +1,4 @@
 {"compressed":"12345,67"}
 {"compressed":"+12345,67"}
 {"compressed":"-12345,67"}
+{"compressed":""}

internal/appli/command/testdata/fold/13-comp3/stdout.jsonl

@@ -2,3 +2,4 @@
 {"compressed":"+12345,67"}
 {"compressed":"-12345.67"}
 {"compressed":"123,45"}
+{"compressed":""}

internal/appli/command/testdata/unfold/13-comp3/stdin.jsonl

@@ -110,18 +110,13 @@ func (u *Unfold) execute(cmd *cobra.Command, _ []string) error {
 }
 
 func (u *Unfold) execUntilEOF(cfg config.Config, buffer api.Buffer, reader document.Reader, record api.Record) error {
-	space, err := charsets.GetByteInCharset(u.charset, ' ')
-	if err != nil {
-		return fmt.Errorf("failed to get space in charset : %w", err)
-	}
-
 	sep, err := charsets.GetBytesInCharset(u.charset, cfg.Separator)
 	if err != nil {
 		return fmt.Errorf("failed to get separator in charset : %w", err)
 	}
 
 	for {
-		if err := buffer.Reset(space, cfg.Length, sep...); err != nil {
+		if err := buffer.Reset(0, cfg.Length, sep...); err != nil {
 			return fmt.Errorf("failed to dump buffer : %w", err)
 		}
 

internal/appli/command/testdata/unfold/13-comp3/stdout.fixed-width

@@ -79,7 +79,7 @@ func (c *Comp3) Decode(buffer api.Buffer, offset int) (any, error) {
 	}
 
 	if isNull(bytes) {
-		return nil, nil //nolint:nilnil
+		return "", nil
 	}
 
 	for byteIndex, byteVal := range bytes {
@@ -94,10 +94,7 @@ func (c *Comp3) Decode(buffer api.Buffer, offset int) (any, error) {
 				result.WriteRune(convertNibbleToRune(high))
 			}
 
-			sign, err := handleSign(byteVal)
-			if err != nil {
-				return result.String(), err
-			}
+			sign := handleSign(byteVal)
 
 			return sign + result.String(), nil
 		}
@@ -115,7 +112,7 @@ func (c *Comp3) Decode(buffer api.Buffer, offset int) (any, error) {
 }
 
 func (c *Comp3) Encode(buffer api.Buffer, offset int, value any) error {
-	if value == nil {
+	if value == "" {
 		// write null value (all bytes set to zero)
 		if err := buffer.Write(offset, make([]byte, c.size)); err != nil {
 			return fmt.Errorf("%w", err)
@@ -263,21 +260,21 @@ func convertRuneToNibble(runeVal rune) (byte, error) {
 	return 0, fmt.Errorf("%w: invalid rune %q", ErrInvalidComp3Nibble, runeVal)
 }
 
-func handleSign(byteVal byte) (string, error) {
+func handleSign(byteVal byte) string {
 	signNibble := byteVal & lowNibbleMask
 
 	if signNibble != signNibblePositive && signNibble != signNibbleNegative && signNibble != signNibbleZero {
-		return "", fmt.Errorf("%w: 0x%X", ErrInvalidComp3Sign, signNibble)
+		return "#"
 	}
 
 	switch signNibble {
 	case signNibbleNegative:
-		return "-", nil
+		return "-"
 	case signNibblePositive:
-		return "+", nil
+		return "+"
 	}
 
-	return "", nil
+	return ""
 }
 
 func isNull(bytes []byte) bool {

internal/appli/command/testdata/unfold/99-import-order/stdout.fixed-width

@@ -71,8 +71,15 @@ func TestComp3_Decode(t *testing.T) {
 			intDigits: 5,
 			decDigits: 2,
 			sep:       '.',
-			expected:  "12345.67",
-			wantErr:   true,
+			expected:  "#12345.67",
+		},
+		{
+			name:      "invalid digit nibble",
+			data:      []byte{0x12, 0x3A, 0x5C},
+			intDigits: 2,
+			decDigits: 3,
+			sep:       '.',
+			expected:  "+12.3A5",
 		},
 		{
 			name:      "short buffer",
@@ -128,7 +135,7 @@ func TestComp3_Decode(t *testing.T) {
 			intDigits: 5,
 			decDigits: 2,
 			sep:       ',',
-			expected:  nil,
+			expected:  "", // null value is decoded as empty string
 		},
 	}
 
@@ -255,8 +262,7 @@ func TestComp3_Encode(t *testing.T) {
 			intDigits: 5,
 			decDigits: 2,
 			sep:       '.',
-			expected:  []byte{},
-			wantErr:   true,
+			expected:  []byte{0x00, 0x00, 0x00, 0x00},
 		},
 		{
 			name:      "misplaced decimal",
@@ -293,14 +299,6 @@ func TestComp3_Encode(t *testing.T) {
 			sep:       '.', // even if the expected separator is '.', accept ',' in input
 			expected:  []byte{0x12, 0x34, 0x56, 0x7C},
 		},
-		{
-			name:      "null value",
-			value:     nil,
-			intDigits: 5,
-			decDigits: 2,
-			sep:       '.',
-			expected:  []byte{0x00, 0x00, 0x00, 0x00},
-		},
 	}
 
 	for _, testcase := range tests {