Skip to content

Commit f8aff71

Browse files
authored
Refactor (#695)
1 parent bbb1f25 commit f8aff71

File tree

3 files changed

+5
-20
lines changed

3 files changed

+5
-20
lines changed

squidApp/src/main/java/org/cirdles/squid/gui/TaskEditorController.java

+5-17
Original file line numberDiff line numberDiff line change
@@ -294,18 +294,6 @@ public void initialize(URL url, ResourceBundle rb) {
294294
SquidPersistentState.getExistingPersistentState().setTaskDesign(new TaskDesignBlank());
295295
taskEditor = SquidPersistentState.getExistingPersistentState().getTaskDesign();
296296
break;
297-
case EDIT_DEFAULT_9_MASS:
298-
SquidPersistentState.getExistingPersistentState().setTaskDesign(new TaskDesign9Mass());
299-
taskEditor = SquidPersistentState.getExistingPersistentState().getTaskDesign();
300-
break;
301-
case EDIT_DEFAULT_10_MASS:
302-
SquidPersistentState.getExistingPersistentState().setTaskDesign(new TaskDesign10Mass());
303-
taskEditor = SquidPersistentState.getExistingPersistentState().getTaskDesign();
304-
break;
305-
case EDIT_DEFAULT_11_MASS:
306-
SquidPersistentState.getExistingPersistentState().setTaskDesign(new TaskDesign11Mass());
307-
taskEditor = SquidPersistentState.getExistingPersistentState().getTaskDesign();
308-
break;
309297
case EDIT_EXISTING_TASK:
310298
existingTaskToEdit.updateTaskDesignFromTask(taskEditor, true);
311299
break;
@@ -382,9 +370,9 @@ private void initTaskDesign() throws SquidException {
382370
}
383371
});
384372

385-
SpinnerValueFactory<Integer> valueFactoryTh
386-
= new SpinnerValueFactory.IntegerSpinnerValueFactory(0, 25, squidProject.getTask().getIndexOfBackgroundSpecies() + 1, 1);
387-
backgroundIndexSpinner.setValueFactory(valueFactoryTh);
373+
SpinnerValueFactory<Integer> valueFactoryBackgroundIndex
374+
= new SpinnerValueFactory.IntegerSpinnerValueFactory(0, 25, taskEditor.getIndexOfBackgroundSpecies() + 1, 1);
375+
backgroundIndexSpinner.setValueFactory(valueFactoryBackgroundIndex);
388376
backgroundIndexSpinner.valueProperty().addListener((ObservableValue<? extends Integer> observable,
389377
Integer oldValue, Integer newValue) -> {
390378

@@ -498,8 +486,8 @@ private void populateRatios() {
498486
}
499487

500488
private void updateDirectiveButtons() {
501-
taskManagerGridPane.lookup("#232").setDisable(squidProject.getTask().getSelectedIndexIsotope().compareTo(Squid3Constants.IndexIsoptopesEnum.PB_208) == 0);
502-
taskManagerGridPane.lookup("#direct").setDisable(squidProject.getTask().getSelectedIndexIsotope().compareTo(Squid3Constants.IndexIsoptopesEnum.PB_208) == 0);
489+
taskManagerGridPane.lookup("#232").setDisable(taskEditor.getSelectedIndexIsotope().compareTo(Squid3Constants.IndexIsoptopesEnum.PB_208) == 0);
490+
taskManagerGridPane.lookup("#direct").setDisable(taskEditor.getSelectedIndexIsotope().compareTo(Squid3Constants.IndexIsoptopesEnum.PB_208) == 0);
503491
}
504492

505493
private void populateDirectives() {

squidCore/src/main/java/org/cirdles/squid/constants/Squid3Constants.java

-3
Original file line numberDiff line numberDiff line change
@@ -405,9 +405,6 @@ public enum TaskEditTypeEnum {
405405
EDIT_COPY_CURRENT("EDIT_COPY_CURRENT"),
406406
EDIT_COPY_CURRENT_NO_EXP("EDIT_COPY_CURRENT_NO_EXP"),
407407
EDIT_EMPTY("EDIT_EMPTY"),
408-
EDIT_DEFAULT_9_MASS("EDIT_DEFAULT_9_MASS"),
409-
EDIT_DEFAULT_10_MASS("EDIT_DEFAULT_10_MASS"),
410-
EDIT_DEFAULT_11_MASS("EDIT_DEFAULT_11_MASS"),
411408
EDIT_EXISTING_TASK("EDIT_EXISTING_TASK");
412409

413410
private final String name;
Binary file not shown.

0 commit comments

Comments
 (0)