fcgi/Client: convert pool pointer to reference

Author: MaxKellermann

src/fcgi/Client.cxx

@@ -1315,7 +1315,7 @@ FcgiClient::FcgiClient(struct pool &_pool,
 }
 
 void
-fcgi_client_request(struct pool *pool,
+fcgi_client_request(struct pool &pool,
 		    StopwatchPtr stopwatch,
 		    BufferedSocket &socket, Lease &lease,
 		    HttpMethod method, const char *uri,
@@ -1407,20 +1407,20 @@ fcgi_client_request(struct pool *pool,
 
 	if (body)
 		/* format the request body */
-		request = NewConcatIstream(*pool,
-					   istream_gb_new(*pool, std::move(buffer)),
-					   istream_fcgi_new(*pool, std::move(body),
+		request = NewConcatIstream(pool,
+					   istream_gb_new(pool, std::move(buffer)),
+					   istream_fcgi_new(pool, std::move(body),
 							    header.request_id));
 	else {
 		/* no request body - append an empty STDIN packet */
 		header.type = FcgiRecordType::STDIN;
 		header.content_length = 0;
 		buffer.WriteT(header);
 
-		request = istream_gb_new(*pool, std::move(buffer));
+		request = istream_gb_new(pool, std::move(buffer));
 	}
 
-	auto client = NewFromPool<FcgiClient>(*pool, *pool,
+	auto client = NewFromPool<FcgiClient>(pool, pool,
 					      std::move(stopwatch),
 					      socket, lease,
 					      std::move(stderr_fd),

src/fcgi/Client.hxx

@@ -50,7 +50,7 @@ IsFcgiClientRetryFailure(const std::exception_ptr &error) noexcept;
  * @param async_ref a handle which may be used to abort the operation
  */
 void
-fcgi_client_request(struct pool *pool,
+fcgi_client_request(struct pool &pool,
 		    StopwatchPtr stopwatch,
 		    BufferedSocket &socket, Lease &lease,
 		    HttpMethod method, const char *uri,

src/fcgi/Remote.cxx

@@ -127,7 +127,7 @@ FcgiRemoteRequest::OnStockItemReady(StockItem &item) noexcept
 	stock_item = &item;
 	cancel_ptr = {};
 
-	fcgi_client_request(&pool, std::move(stopwatch),
+	fcgi_client_request(pool, std::move(stopwatch),
 			    tcp_stock_item_get(item),
 			    *this,
 			    pending_request.method, pending_request.uri,

src/fcgi/Request.cxx

@@ -171,7 +171,7 @@ FcgiRequest::OnStockItemReady(StockItem &item) noexcept
 
 	const char *script_filename = address.path;
 
-	fcgi_client_request(&pool, std::move(stopwatch),
+	fcgi_client_request(pool, std::move(stopwatch),
 			    fcgi_stock_item_get(*stock_item),
 			    *this,
 			    pending_request.method, pending_request.uri,

test/t_fcgi_client.cxx

@@ -255,7 +255,7 @@ class FcgiClientConnection final : public ClientConnection {
 		     [[maybe_unused]] bool expect_100,
 		     HttpResponseHandler &handler,
 		     CancellablePointer &cancel_ptr) noexcept override {
-		fcgi_client_request(&pool, nullptr,
+		fcgi_client_request(pool, nullptr,
 				    socket, lease,
 				    method, uri, uri, nullptr, nullptr, nullptr,
 				    nullptr, "192.168.1.100",