fixed failing tests and added unique tests

Author: sachin-panayil

backend/npdfhir/tests.py

@@ -184,8 +184,45 @@ def test_list_filter_by_organization_type(self):
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertIn("results", response.data)
 
+    def test_list_filter_by_npi_general(self):
+        url = reverse("fhir-organization-list")
+        response = self.client.get(url, {"identifier":"1427051473"})
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertIn("results", response.data)
+
+    def test_list_filter_by_npi_specific(self):
+        url = reverse("fhir-organization-list")
+        response = self.client.get(url, {"identifier":"NPI|1427051473"})
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertIn("results", response.data)
+
+    # this test data is not in the database yet so no point of including them but this is what the test should look like when we eventually do get them in
+
+    # def test_list_filter_by_ein_general(self):
+    #     url = reverse("fhir-organization-list")
+    #     response = self.client.get(url, {"identifier":"12-3456789"})
+    #     self.assertEqual(response.status_code, status.HTTP_200_OK)
+    #     self.assertIn("results", response.data)
+
+    # def test_list_filter_by_ein_specific(self):
+    #     url = reverse("fhir-organization-list")
+    #     response = self.client.get(url, {"identifier":"USEIN|12-3456789"})
+    #     self.assertEqual(response.status_code, status.HTTP_200_OK)
+    #     self.assertIn("results", response.data)
+    # def test_list_filter_by_otherID_general(self):
+    #     url = reverse("fhir-organization-list")
+    #     response = self.client.get(url, {"identifier":"1EG4-TE5-MK73"})
+    #     self.assertEqual(response.status_code, status.HTTP_200_OK)
+    #     self.assertIn("results", response.data)
+
+    # def test_list_filter_by_otherID_specific(self):
+    #     url = reverse("fhir-organization-list")
+    #     response = self.client.get(url, {"identifier":"	CmsMBI|1EG4-TE5-MK73"})
+    #     self.assertEqual(response.status_code, status.HTTP_200_OK)
+    #     self.assertIn("results", response.data)
+
     def test_retrieve_nonexistent(self):
-        url = reverse("fhir-organization-detail", args=[999999])
+        url = reverse("fhir-organization-detail", args=["12300000-0000-0000-0000-000000000123"])
         response = self.client.get(url)
         self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
 
@@ -246,6 +283,6 @@ def test_list_filter_by_practitioner_type(self):
         self.assertIn("results", response.data)
 
     def test_retrieve_nonexistent(self):
-        url = reverse("fhir-practitioner-detail", args=[999999])
+        url = reverse("fhir-practitioner-detail", args=["12300000-0000-0000-0000-000000000123"])
         response = self.client.get(url)
         self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)

backend/npdfhir/views.py

@@ -429,7 +429,7 @@ def list(self, request):
                 case 'organization_type':
                     organizations = organizations.annotate(
                         search=SearchVector(
-                            'organizationtotaxonomy__nucc_code__display_name')
+                            'clinicalorganization__organizationtotaxonomy__nucc_code__display_name')
                     ).filter(search=value)
                 case 'address':
                     organizations = organizations.annotate(