address PR comments

* rename provider_search to provider_directory
* clarify behavior of provider_directory.views.landing in development
* write some tests about it

Author: abachman-dsac

backend/app/settings.py

@@ -31,6 +31,8 @@
 
 # SECURITY WARNING: don't run with debug turned on in production!
 DEBUG = bool(config('DEBUG'))
+TESTING = sys.argv[1:2] == ['test']
+
 
 if DEBUG:
     ALLOWED_HOSTS = ['localhost', '127.0.0.1']
@@ -54,7 +56,7 @@
     'django_filters',
     'drf_yasg',
     'xmlrunner',
-    'provider_search.apps.ProviderSearch',
+    'provider_directory.apps.ProviderDirectory',
 ]
 
 if not TESTING:
@@ -87,9 +89,9 @@
         'BACKEND': 'django.template.backends.django.DjangoTemplates',
         'DIRS': [
             # NOTE: (@abachman-dsac) this setup allows frontend/ to build directly
-            # into provider_search/static/ and provider_search.views.landing to
+            # into provider_directory/static/ and provider_directory.views.landing to
             # reference the resulting index.html
-            os.path.join(BASE_DIR, 'provider_search', 'static'),
+            os.path.join(BASE_DIR, 'provider_directory', 'static'),
         ],
         'APP_DIRS': True,
         'OPTIONS': {
@@ -169,7 +171,7 @@
 
 STATICFILES_DIRS = [
     os.path.join(BASE_DIR, 'static'),
-    os.path.join(BASE_DIR, 'provider_search', 'static'),
+    os.path.join(BASE_DIR, 'provider_directory', 'static'),
 ]
 
 # STATICFILES_DIRS = [

backend/app/urls.py

@@ -21,5 +21,5 @@
 urlpatterns = [
     path('fhir/', include("npdfhir.urls")),
     path('admin/', admin.site.urls),
-    path('', include('provider_search.urls')),
+    path('', include('provider_directory.urls')),
 ] + debug_toolbar_urls()

backend/provider_search/.gitignore backend/provider_directory/.gitignorebackend/provider_search/.gitignore renamed to backend/provider_directory/.gitignore

@@ -1,5 +1,5 @@
 from django.apps import AppConfig
 
-class ProviderSearch(AppConfig):
+class ProviderDirectory(AppConfig):
     default_auto_field = 'django.db.models.BigAutoField'
-    name = 'provider_search'
+    name = 'provider_directory'

backend/provider_search/README.md backend/provider_directory/README.mdbackend/provider_search/README.md renamed to backend/provider_directory/README.md

@@ -0,0 +1,44 @@
+from datetime import datetime
+from http import HTTPStatus
+import os
+from pathlib import Path
+from django.test import TestCase
+from django.urls import reverse
+
+TEST_DIR = Path(os.path.dirname(os.path.abspath(__file__)))
+STATIC_INDEX = TEST_DIR / '..' / 'static' / 'index.html'
+
+class WithoutStaticIndex(TestCase):
+    """
+    Visiting the index route when no static/index.html asset exists.
+    """
+
+    @classmethod
+    def setUpTestData(cls):
+        if os.path.exists(STATIC_INDEX):
+            os.unlink(STATIC_INDEX)
+
+    def test_index_redirects_to_vite_in_development(self):
+        """
+        When static/index.html doesn't exist, route redirects
+        """
+        response = self.client.get(reverse('index'))
+        self.assertRedirects(response, 'http://localhost:3000/', fetch_redirect_response=False)
+
+class WithStaticIndex(TestCase):
+    """
+    Visiting the index route when static/index.html asset does exist.
+    """
+
+    @classmethod
+    def setUpTestData(cls):
+        if not os.path.exists(STATIC_INDEX):
+            with open(STATIC_INDEX, 'a') as index:
+                index.write(f'\n<!-- test content {datetime.now()} -->')
+
+    def test_index_serves_static_file(self):
+        """
+        When static/index.html exists, route serves it
+        """
+        response = self.client.get(reverse('index'))
+        self.assertContains(response, 'test content', status_code=HTTPStatus.OK)