feature: upgrade Spring Boot 2.0.2 -> 4.1.1 (Java 17) incrementally - #79
Open
devin-ai-integration[bot] wants to merge 19 commits into
Open
devin-ai-integration[bot] wants to merge 19 commits into
devin-ai-integration[bot] wants to merge 19 commits into
Conversation
…nd an executable jar is produced Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
…ternal quote service is unreachable Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
…dd spring-boot-starter-actuator for health checks Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
…apper) with varargs form for Spring Framework 7 Co-Authored-By: Chris Livingston <chris.livingston@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the app from Spring Boot 2.0.2.RELEASE / Java 8 (what
masteractually had — not 2.7.18) to Spring Boot 4.1.1 / Java 17, one minor version at a time with one commit per step. At every stepmvn clean verifypassed and the jar was started and smoke-tested (/topic,/topic/java,/?name=Devin, banner version checked).Upgrade path (one commit each)
2.0.2.RELEASE → 2.1.18.RELEASE → 2.2.13.RELEASE → 2.3.12.RELEASE → 2.4.13 → 2.5.15 → 2.6.15 → 2.7.18 → 3.0.13 → 3.1.12 → 3.2.12 → 3.3.13 → 3.4.13 → 3.5.16 → 4.0.8 → 4.1.1Breaking changes handled
<packaging>pom</packaging>→jar. Withpompackaging Maven compiled nothing and produced no jar, so the "build" was a no-op and the app could not be run.UnknownHostException: gturnquist-quoters.cfapps.io(dead demo quote service called frommainand aCommandLineRunner). Wrapped the call inlogRandomQuote()which logs a WARN onRestClientExceptioninstead of failing startup.spring-boot-properties-migratorreported no deprecated/renamed properties (the only property,server.port, is commented out).java.version1.8 → 17. Nojavax.*imports exist in the code base, so nojakarta.*migration was required. Properties migrator stayed on the classpath through 3.x and reported nothing.spring-boot-starter-web→spring-boot-starter-webmvc(old starter deprecated);RestTemplateBuildermoved toorg.springframework.boot.restclient.RestTemplateBuilderin the newspring-boot-restclientmodule, sospring-boot-starter-restclientwas added. Java baseline remains 17 (4.0/4.1 require 17+, no bump needed).spring-boot-properties-migrator(migration guide says to remove it once done). Addedspring-boot-starter-actuatorso/actuator/healthis available. Replaced the Spring Framework 7–deprecatedJdbcTemplate.query(String, Object[], RowMapper)with the varargs overloadquery(String, RowMapper, Object...)so the build is deprecation-warning free.Not changed
build.gradle(still references Spring Boot 2.0.2 / Gradlecompileconfig) was left as-is; the Maven build is the one used by CI/blueprint. Happy to update in a follow-up if wanted.target/build artifacts were not re-committed.src/test, so nothing to run there.Verification (Spring Boot 4.1.1, Java 17)
Full log in the attached
springboot-4.1.1-evidence.txt(session attachment). Excerpt:Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/6e5668cfa0694943861c66ec8c141646
Open in Devin Desktop: https://app.devin.ai/desktop/session/6e5668cfa0694943861c66ec8c141646?variant=devin
Requested by: @clivingston-cognition
Note
Devin errored when opening this Pull Request as clivingston-cognition.
As a fallback, Devin opened this PR as itself.