Commit a7a00a4
docs(map): correct decoy_thresh comment (strict domination, ties keep transcript)
The doc comment described `best_decoy >= decoy_thresh * best_valid` (drop on
tie), but the code uses strict `<` (`best_valid < decoy_thresh * best_decoy`): a
fragment is assigned to a decoy only when the decoy is *strictly* better, so at
the default decoy_thresh=1.0 a decoy that merely ties the best transcript does
NOT dominate and the transcript is kept. This matches C++ salmon's
`bestScore < decoyThresh * bestDecoyScore`. Comment-only.
Investigated + reverted an experimental C++ --denyDecoyOrphans flag: testing
showed C++ already applies this exact strict-domination rule (so a faithful
mirror is a no-op), and a blunt "drop any orphan co-occurring with a decoy"
variant over-dropped (90.9% vs Rust default 93.7%). The real C++/Rust residual is
seeding (Rust surfaces dominating genome pairs C++ does not), not decoy policy.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B7JMur5DmDpECddErpi2JS1 parent 4908cd1 commit a7a00a4
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
82 | 86 | | |
83 | 87 | | |
84 | 88 | | |
| |||
0 commit comments