diff --git a/src/vss_tools/model.py b/src/vss_tools/model.py index 30a3665c..c69fa9b6 100644 --- a/src/vss_tools/model.py +++ b/src/vss_tools/model.py @@ -260,7 +260,7 @@ def check_min_max_valid_datatype(self) -> Self: return self def check_default_min_max(self) -> Self: - if not self.default: + if self.default is None: return self values = [self.default] if isinstance(self.default, list): diff --git a/tests/test_model.py b/tests/test_model.py index 8655aa9e..ddd79b37 100644 --- a/tests/test_model.py +++ b/tests/test_model.py @@ -31,6 +31,9 @@ ({"datatype": "uint8", "max": 100, "default": 90}, True), ({"datatype": "uint8", "min": 10, "default": 5}, False), ({"datatype": "uint8", "min": 10, "default": 10}, True), + ({"datatype": "uint8", "min": 1, "default": 0}, False), + ({"datatype": "int8", "max": -1, "default": 0}, False), + ({"datatype": "uint8", "min": 0, "default": 0}, True), ({"datatype": "uint8", "default": 300}, False), ({"datatype": "uint8", "default": 200}, True), ({"datatype": "boolean", "default": True}, True),