df2 rows assigned incorrectly

ahgamut · ahgamut · commit 54fda2442131 · 2025-09-24T10:47:23.000-05:00
if df2 is different from df, assigning writer based on number of rows
of df causes an error. this patch fixes that, allowing M x N comparisons
to work smoothly.
diff --git a/R/distances.R b/R/distances.R
@@ -91,7 +91,7 @@ get_distances <- function(df, distance_measures, df2 = NULL) {
   if (is.null(df2)) {
     df2 <- df
   } else if (!("writer" %in% colnames(df2))) {
-    df2$writer <- paste0("df2_unknown", 1:nrow(df))
+    df2$writer <- paste0("df2_unknown", 1:nrow(df2))
   }
 
   for (method in distance_measures) {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ get_distances <- function(df, distance_measures, df2 = NULL) {`
`91`	`91`	`if (is.null(df2)) {`
`92`	`92`	`df2 <- df`
`93`	`93`	`} else if (!("writer" %in% colnames(df2))) {`
`94`		`- df2$writer <- paste0("df2_unknown", 1:nrow(df))`
	`94`	`+ df2$writer <- paste0("df2_unknown", 1:nrow(df2))`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`for (method in distance_measures) {`