Skip to content

Commit 2c5708a

Browse files
committed
adding docs directory, and setting up modules
1 parent 6b59c47 commit 2c5708a

37 files changed

+186
-74
lines changed

client/__init__.py

Whitespace-only changes.

client/container_preparation/__init__.py

Whitespace-only changes.

client/container_preparation/lib/__init__.py

Whitespace-only changes.

client/container_preparation/lib/image_build.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from dockerfile_parse import DockerfileParser
22
import os, sys
3-
from tools.docker.docker_utils import build_build_env, check_build_env_exists
3+
from client.container_preparation.tools.docker.docker_utils import build_build_env, check_build_env_exists
44

55
sys.path.append(os.path.expanduser("../../../")) # For cli usage
66
sys.path.append(os.path.expanduser("../../")) # For inside-container usage

client/container_preparation/prepare_container.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
from tools.docker.docker_utils import check_docker_socket_access
2-
from lib.image_build import build_prepared_image, create_sif_image
3-
from tools.cli.cli import parse_arguments
1+
from client.container_preparation.tools.docker.docker_utils import check_docker_socket_access
2+
from client.container_preparation.lib.image_build import build_prepared_image, create_sif_image
3+
from client.container_preparation.tools.cli.cli import parse_arguments
44
from docker import DockerClient
55

66

client/container_preparation/tools/__init__.py

Whitespace-only changes.

client/container_preparation/tools/cli/__init__.py

Whitespace-only changes.

client/container_preparation/tools/cli/cli.py

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import argparse
22

3-
43
# Parse arguments from the cli
54
def parse_arguments() -> argparse.ArgumentParser:
65
"""Parse arguments from the cli

client/container_preparation/tools/docker/__init__.py

Whitespace-only changes.

client/data_preparation/__init__.py

Whitespace-only changes.

client/data_preparation/lib/__init__.py

Whitespace-only changes.

client/data_preparation/prepare_data.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
from tools.cli.cli import parse_arguments
2-
from tools.utils import check_arguments
1+
from client.data_preparation.tools.cli.cli import parse_arguments, check_arguments
32
from pyrage import x25519, encrypt
43
from os import path, remove
54
import tarfile

client/data_preparation/tools/__init__.py

Whitespace-only changes.

client/data_preparation/tools/cli/__init__.py

Whitespace-only changes.

client/data_preparation/tools/cli/cli.py

+26-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import argparse
2-
2+
from os.path import isfile, isdir
33

44
# Parse arguments from the cli
55
def parse_arguments() -> argparse.ArgumentParser:
@@ -22,3 +22,28 @@ def parse_arguments() -> argparse.ArgumentParser:
2222
)
2323

2424
return parser.parse_args()
25+
26+
def check_arguments(input_path: str, output_path: str) -> bool:
27+
"""Check cli arguments for data preparation and check wether or not input is a file
28+
29+
Args:
30+
input_path (str): Path to the input file or directory
31+
output_path (str): Path to the output directory
32+
33+
Returns:
34+
bool: Wether or not the input is a file
35+
"""
36+
37+
# Check input path exists, store wether it's a file or a directory
38+
try:
39+
input_is_file = isfile(input_path)
40+
except FileNotFoundError:
41+
print(f"File {input_path} doesn't exist.")
42+
43+
# Check output path exists, and it's a directory
44+
try:
45+
isdir(input_path)
46+
except FileNotFoundError:
47+
print(f"Directory {output_path} doesn't exist.")
48+
49+
return input_is_file

client/data_preparation/tools/utils.py

-27
This file was deleted.

client/job_preparation/__init__.py

Whitespace-only changes.

client/job_preparation/lib/__init__.py

Whitespace-only changes.

client/job_preparation/prepare_job.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
from utils.cli.cli import parse_arguments, check_arguments
2-
from lib.sbatch_generation import sbatch_from_template
3-
from lib.info_file import get_info_from_infofile
4-
import sys, os
5-
6-
sys.path.append(os.path.expanduser("../../../")) # For cli usage
7-
sys.path.append(os.path.expanduser("../../")) # For inside-container usage
1+
from client.job_preparation.utils.cli.cli import parse_arguments, check_arguments
2+
from client.job_preparation.lib.sbatch_generation import sbatch_from_template
3+
from client.job_preparation.lib.info_file import get_info_from_infofile
84
from utils.ssh_utils import ssh_connect, ssh_copy_file, ssh_run_command
95
from utils.conf.client.conf import parse_configuration
106
from time import sleep

client/job_preparation/utils/__init__.py

Whitespace-only changes.

client/job_preparation/utils/cli/__init__.py

Whitespace-only changes.

docs/Makefile

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Minimal makefile for Sphinx documentation
2+
#
3+
4+
# You can set these variables from the command line, and also
5+
# from the environment for the first two.
6+
SPHINXOPTS ?=
7+
SPHINXBUILD ?= sphinx-build
8+
SOURCEDIR = .
9+
BUILDDIR = _build
10+
11+
# Put it first so that "make" without argument is like "make help".
12+
help:
13+
@$(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
14+
15+
.PHONY: help Makefile
16+
17+
# Catch-all target: route all unknown targets to Sphinx using the new
18+
# "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS).
19+
%: Makefile
20+
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)

docs/conf.py

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Configuration file for the Sphinx documentation builder.
2+
#
3+
# For the full list of built-in configuration values, see the documentation:
4+
# https://www.sphinx-doc.org/en/master/usage/configuration.html
5+
6+
# -- Project information -----------------------------------------------------
7+
# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information
8+
9+
import sys, os
10+
sys.path.insert(0, os.path.abspath('..'))
11+
12+
project = 'HPCS'
13+
copyright = '2024, Martin Matthiesen, Emilien Tellier'
14+
author = 'Martin Matthiesen, Emilien Tellier'
15+
release = '0.1.0'
16+
17+
# -- General configuration ---------------------------------------------------
18+
# https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration
19+
20+
extensions = ['sphinx.ext.todo', 'sphinx.ext.viewcode', 'sphinx.ext.autodoc']
21+
22+
templates_path = ['_templates']
23+
exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store']
24+
25+
26+
27+
# -- Options for HTML output -------------------------------------------------
28+
# https://www.sphinx-doc.org/en/master/usage/configuration.html#options-for-html-output
29+
30+
html_theme = 'alabaster'
31+
html_static_path = ['_static']

docs/index.rst

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
.. HPCS documentation master file, created by
2+
sphinx-quickstart on Tue Mar 19 13:07:16 2024.
3+
You can adapt this file completely to your liking, but it should at least
4+
contain the root `toctree` directive.
5+
6+
Welcome to HPCS's documentation!
7+
================================
8+
9+
.. toctree::
10+
:maxdepth: 2
11+
:caption: Contents:
12+
13+
modules
14+
15+
16+
17+
Indices and tables
18+
==================
19+
20+
* :ref:`genindex`
21+
* :ref:`modindex`
22+
* :ref:`search`

docs/make.bat

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
@ECHO OFF
2+
3+
pushd %~dp0
4+
5+
REM Command file for Sphinx documentation
6+
7+
if "%SPHINXBUILD%" == "" (
8+
set SPHINXBUILD=sphinx-build
9+
)
10+
set SOURCEDIR=.
11+
set BUILDDIR=_build
12+
13+
%SPHINXBUILD% >NUL 2>NUL
14+
if errorlevel 9009 (
15+
echo.
16+
echo.The 'sphinx-build' command was not found. Make sure you have Sphinx
17+
echo.installed, then set the SPHINXBUILD environment variable to point
18+
echo.to the full path of the 'sphinx-build' executable. Alternatively you
19+
echo.may add the Sphinx directory to PATH.
20+
echo.
21+
echo.If you don't have Sphinx installed, grab it from
22+
echo.https://www.sphinx-doc.org/
23+
exit /b 1
24+
)
25+
26+
if "%1" == "" goto help
27+
28+
%SPHINXBUILD% -M %1 %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
29+
goto end
30+
31+
:help
32+
%SPHINXBUILD% -M help %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
33+
34+
:end
35+
popd

server/__init__.py

Whitespace-only changes.

server/app.py

+24-21
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
1-
import hashlib, sys, os
1+
import hashlib
22
from quart import Quart, jsonify, request
3-
from lib.spire_interactions import (
3+
from pyspiffe.spiffe_id.spiffe_id import SpiffeId
4+
from pyspiffe.spiffe_id.spiffe_id import SpiffeId
5+
6+
from server.lib.spire_interactions import (
47
token_generate,
58
entry_create,
69
get_server_identity_JWT,
710
validate_client_JWT_SVID,
811
)
9-
from lib import spire_interactions
10-
from tools.docker_utils import get_build_env_image_digests
11-
from pyspiffe.spiffe_id.spiffe_id import SpiffeId
12-
13-
from tools.config.config import parse_configuration
14-
from tools.cli.cli import parse_arguments
12+
from server.lib import spire_interactions
13+
from server.tools.docker_utils import get_build_env_image_digests
14+
from server.tools.config.config import parse_configuration
15+
from server.tools.cli.cli import parse_arguments
1516
from utils.vault.vault_utils import (
1617
vault_login,
1718
write_client_policy,
@@ -22,22 +23,24 @@
2223

2324
app = Quart(__name__)
2425

25-
options = parse_arguments()
26-
configuration = parse_configuration(options.config)
26+
if __name__ == "__main__":
27+
28+
options = parse_arguments()
29+
configuration = parse_configuration(options.config)
2730

28-
if configuration['spire-server'].get('spire-server-bin') :
29-
spire_interactions.spire_server_bin = configuration['spire-server']['spire-server-bin']
31+
if configuration['spire-server'].get('spire-server-bin') :
32+
spire_interactions.spire_server_bin = configuration['spire-server']['spire-server-bin']
3033

31-
if configuration['spire-server'].get('pre-command') :
32-
spire_interactions.pre_command = configuration['spire-server']['pre-command']
33-
if configuration['spire-server']['pre-command'] == "\"\"":
34-
spire_interactions.pre_command = ""
35-
36-
# Defining the trust domain (SPIRE Trust Domain)
37-
trust_domain = configuration['spire-server']['trust-domain']
34+
if configuration['spire-server'].get('pre-command') :
35+
spire_interactions.pre_command = configuration['spire-server']['pre-command']
36+
if configuration['spire-server']['pre-command'] == "\"\"":
37+
spire_interactions.pre_command = ""
38+
39+
# Defining the trust domain (SPIRE Trust Domain)
40+
trust_domain = configuration['spire-server']['trust-domain']
3841

39-
# Perform vault login, to be able to run later operations against vault
40-
hvac_client = vault_login(configuration['vault']['url'], get_server_identity_JWT(), configuration['vault']['server-role'])
42+
# Perform vault login, to be able to run later operations against vault
43+
hvac_client = vault_login(configuration['vault']['url'], get_server_identity_JWT(), configuration['vault']['server-role'])
4144

4245

4346
# Dummy endpoint that handles the registration of compute nodes.

server/lib/__init__.py

Whitespace-only changes.

server/lib/spire_interactions.py

+11-5
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,11 @@ def entry_create(
6767
return subprocess.run(command, capture_output=True)
6868

6969

70-
def get_server_identity_JWT() -> JwtSvid:
70+
def get_server_identity_JWT(JwtSource : default_jwt_source.DefaultJwtSource) -> JwtSvid:
7171
"""Get jwt SVID of the server
7272
73+
Args:
74+
JwtSource (default_jwt_source.DefaultJwtSource): connection to the spire agent workload api
7375
Returns:
7476
JwtSvid: the SVID
7577
"""
@@ -82,28 +84,32 @@ def get_server_identity_JWT() -> JwtSvid:
8284
return SVID
8385

8486

85-
def validate_JWT_SVID(JwtSVID: str) -> JwtSvid:
87+
def validate_JWT_SVID(JwtSource : default_jwt_source.DefaultJwtSource, JwtSVID: str) -> JwtSvid:
8688
"""Validate a provided JWT SVID against spire-agent
8789
90+
Args:
91+
JwtSource (default_jwt_source.DefaultJwtSource): connection to the spire agent workload api
92+
8893
Returns:
8994
JwtSvid: parsed and validated SVID
9095
"""
91-
return jwt_workload_api._workload_api_client.validate_jwt_svid(
96+
return JwtSource._workload_api_client.validate_jwt_svid(
9297
JwtSVID, audience="TESTING"
9398
)
9499

95100

96-
def validate_client_JWT_SVID(JwtSVID: str, client_id: str) -> bool:
101+
def validate_client_JWT_SVID(JwtSource : default_jwt_source.DefaultJwtSource, JwtSVID: str, client_id: str) -> bool:
97102
"""Validate a client JWT, same as `validate_JWT_SVID` plus client_id verification
98103
99104
Args:
105+
JwtSource (default_jwt_source.DefaultJwtSource): connection to the spire agent workload api
100106
JwtSVID (str): the client's JWT SVID
101107
client_id (str): the client's id
102108
103109
Returns:
104110
bool: JWT SVID is valide and matches client id or not
105111
"""
106-
SVID = validate_JWT_SVID(JwtSVID)
112+
SVID = validate_JWT_SVID(JwtSource, JwtSVID)
107113
if str(SVID.spiffe_id).split("/")[-2] != client_id:
108114
return False
109115
return True

server/tools/__init__.py

Whitespace-only changes.

server/tools/config/__init__.py

Whitespace-only changes.

utils/__init__.py

Whitespace-only changes.

utils/conf/__init__.py

Whitespace-only changes.

utils/conf/client/__init__.py

Whitespace-only changes.

utils/ship_a_key.py

+8-5
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
import argparse
2+
import requests
3+
import yaml
4+
25
from re import search
36
from os import path
7+
48
from pyspiffe.workloadapi import default_jwt_source, default_workload_api_client
59
from pyspiffe.spiffe_id import spiffe_id
610
from pyspiffe.exceptions import SpiffeIdError
711
from pyspiffe.svid.jwt_svid import JwtSvid
8-
import requests
9-
from vault.vault_utils import vault_login, write_secret
10-
import yaml
1112
from hashlib import sha512
12-
from ssh_utils import ssh_connect, ssh_copy_file
13-
from conf.client.conf import parse_configuration
13+
14+
from utils.vault.vault_utils import vault_login, write_secret
15+
from utils.ssh_utils import ssh_connect, ssh_copy_file
16+
from utils.conf.client.conf import parse_configuration
1417

1518
# Provide client_id from cli$
1619
# Same for trust domain

utils/spawn_agent.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import platform, argparse, subprocess, requests
2-
from conf.client.conf import parse_configuration
2+
from utils.conf.client.conf import parse_configuration
33

44

55
# Parse arguments from the cli

utils/vault/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)