Fix SelfArchivedCode assignment for profile-only publications (#301)

Author: sarkikos

aspnetcore/src/api.Tests/Services_Tests/Profiledata/PublicationServiceTest.cs

@@ -157,7 +157,7 @@ public async Task GetProfileEditorPublications_ReturnsPublications_WhenMatchingU
             Assert.Equal(2024, result[2].PublicationYear);
             Assert.Equal("DimProfileOnlyPublication2 Publisher name", result[2].PublisherName);
             Assert.Equal("", result[2].SelfArchivedAddress);
-            Assert.Equal("0", result[2].SelfArchivedCode);
+            Assert.Equal("", result[2].SelfArchivedCode);
             Assert.Equal("DimProfileOnlyPublication2 Volume number", result[2].Volume);
             // Item meta
             Assert.NotNull(result[0].itemMeta);
@@ -193,7 +193,7 @@ public async Task GetProfileEditorPublications_ReturnsPublications_WhenMatchingU
             Assert.Equal("", result[3].PublisherName);
             Assert.Equal("", result[3].Volume);
             Assert.Equal("", result[3].SelfArchivedAddress);
-            Assert.Equal("0", result[3].SelfArchivedCode);
+            Assert.Equal("", result[3].SelfArchivedCode);
             // Item meta
             Assert.NotNull(result[3].itemMeta);
             Assert.Equal(23, result[3].itemMeta.Id);

aspnetcore/src/api/Services/Profiledata/PublicationService.cs

@@ -262,6 +262,13 @@ void ProcessItem(PublicationDto newPublication)
                 // Parse open access code. If parsing fails, set to 9 (unknown value).
                 int openAccessCode = int.TryParse(publicationDto.OpenAccessCodeUnprocessed, out int openAccessCodeParsed) ? openAccessCodeParsed : 9;
 
+                // SelfArchivedCode.
+                string selfArchivedCode = "";
+                if (!publicationDto.IsProfileOnlyPublication)
+                {
+                    selfArchivedCode = (publicationDto.SelfArchivedCode != null && (bool)publicationDto.SelfArchivedCode) ? "1" : "0";
+                }
+
                 publications.Add(new ProfileEditorPublication()
                 {
                     ArticleNumberText = publicationDto.ArticleNumberText,
@@ -288,7 +295,7 @@ void ProcessItem(PublicationDto newPublication)
                     PublisherName = publicationDto.PublisherName,
                     PublicationTypeCode = publicationDto.PublicationTypeCode,
                     SelfArchivedAddress = publicationDto.SelfArchivedAddress,
-                    SelfArchivedCode = (publicationDto.SelfArchivedCode != null && (bool)publicationDto.SelfArchivedCode) ? "1" : "0",
+                    SelfArchivedCode = selfArchivedCode,
                     Volume = publicationDto.Volume,
                     DataSources = publicationDto.DataSources.Select(dataSourceDto => new ProfileEditorSource()
                     {