Build error with BitVector.h

[sjmurdoch]

I am getting the following build error, when compiling LLVM on macOS 15.5 using the following command: ./cheribuild.py llvm-riscv64-purecap -d. cheribuild is at revision f755db09 and llvm-project is at revision 578ea4f7ef.

/Users/smurdoch/cheri/llvm-project/llvm/include/llvm/ADT/BitVector.h:841:22: error: no viable conversion from 'pair<[...], ArrayRef<unsigned long>>' to 'const pair<[...], ArrayRef<unsigned __intcap>>'
        getHashValue(std::make_pair(V.size(), V.getData()));
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:92:27: note: candidate constructor not viable: no known conversion from 'pair<typename __unwrap_ref_decay<unsigned int>::type, typename __unwrap_ref_decay<ArrayRef<unsigned long>>::type>' (aka 'pair<unsigned int, llvm::ArrayRef<unsigned long>>') to 'const std::pair<unsigned int, llvm::ArrayRef<unsigned __intcap>> &' for 1st argument
    _LIBCPP_HIDE_FROM_ABI pair(pair const&) = default;
                          ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:93:27: note: candidate constructor not viable: no known conversion from 'pair<typename __unwrap_ref_decay<unsigned int>::type, typename __unwrap_ref_decay<ArrayRef<unsigned long>>::type>' (aka 'pair<unsigned int, llvm::ArrayRef<unsigned long>>') to 'std::pair<unsigned int, llvm::ArrayRef<unsigned __intcap>> &&' for 1st argument
    _LIBCPP_HIDE_FROM_ABI pair(pair&&) = default;
                          ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:254:5: note: candidate template ignored: requirement '_CheckArgs::__enable_implicit()' was not satisfied [with _U1 = unsigned int, _U2 = llvm::ArrayRef<unsigned long>]
    pair(pair<_U1, _U2> const& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:272:5: note: candidate template ignored: requirement '_CheckArgs::__enable_implicit()' was not satisfied [with _U1 = unsigned int, _U2 = llvm::ArrayRef<unsigned long>]
    pair(pair<_U1, _U2>&& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:441:5: note: candidate template ignored: could not match 'tuple' against 'pair'
    pair(tuple<_U1, _U2> const& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:462:5: note: candidate template ignored: could not match 'tuple' against 'pair'
    pair(tuple<_U1, _U2>&& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:507:5: note: candidate template ignored: could not match 'array' against 'pair'
    pair(array<_Up, 2> const& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:528:5: note: candidate template ignored: could not match 'array' against 'pair'
    pair(array<_Up, 2>&& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:245:14: note: explicit constructor is not a candidate
    explicit pair(pair<_U1, _U2> const& __p)
             ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:263:14: note: explicit constructor is not a candidate
    explicit pair(pair<_U1, _U2>&&__p)
             ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:453:5: note: explicit constructor is not a candidate
    pair(tuple<_U1, _U2> const& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:474:5: note: explicit constructor is not a candidate
    pair(tuple<_U1, _U2>&& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:519:5: note: explicit constructor is not a candidate
    pair(array<_Up, 2> const& __p)
    ^
/Users/smurdoch/cheri/output/rootfs-riscv64-purecap/usr/include/c++/v1/__utility/pair.h:540:5: note: explicit constructor is not a candidate
    pair(array<_Up, 2>&& __p)
    ^
/Users/smurdoch/cheri/llvm-project/llvm/include/llvm/ADT/DenseMapInfo.h:260:44: note: passing argument to parameter 'PairVal' here
  static unsigned getHashValue(const Pair& PairVal) {
                                           ^
1 error generated.

[jrtc27]

LLVM does not build as a purecap binary, so don't do that. If you really, truly want to build a version of LLVM that runs on a CHERI-RISC-V system, use llvm-riscv64-hybrid-for-purecap-rootfs, but you should be prepared for the fact that it will be a miserably slow experience on an emulator or FPGA and likely would be better served by cross-compiling (with llvm(-native)).

[sjmurdoch]

Thanks! I got a different error with ./cheribuild.py llvm-riscv64-hybrid-for-purecap-rootfs -d

(but you're right, I probably want llvm-native)

FAILED: [code=134] include/llvm/IR/Attributes.inc /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include/llvm/IR/Attributes.inc 
cd /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build && /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen -gen-attrs -I /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR -I/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include -I/Users/smurdoch/cheri/llvm-project/llvm/include /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR/Attributes.td --write-if-changed -o include/llvm/IR/Attributes.inc -d include/llvm/IR/Attributes.inc.d
dyld[67898]: Library not loaded: @rpath/libzstd.1.dylib
  Referenced from: <D3695FD8-C97C-3CC7-BC5B-E39ED84DD53D> /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen
  Reason: tried: '/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/../lib/libzstd.1.dylib' (no such file), '/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/../lib/libzstd.1.dylib' (no such file)
/bin/sh: line 1: 67898 Abort trap: 6           /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen -gen-attrs -I /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR -I/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include -I/Users/smurdoch/cheri/llvm-project/llvm/include /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR/Attributes.td --write-if-changed -o include/llvm/IR/Attributes.inc -d include/llvm/IR/Attributes.inc.d
[241/3634] Building IntrinsicEnums.inc...
FAILED: [code=134] include/llvm/IR/IntrinsicEnums.inc /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include/llvm/IR/IntrinsicEnums.inc 
cd /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build && /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen -gen-intrinsic-enums -I /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR -I/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include -I/Users/smurdoch/cheri/llvm-project/llvm/include /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR/Intrinsics.td --write-if-changed -o include/llvm/IR/IntrinsicEnums.inc -d include/llvm/IR/IntrinsicEnums.inc.d
dyld[67900]: Library not loaded: @rpath/libzstd.1.dylib
  Referenced from: <D3695FD8-C97C-3CC7-BC5B-E39ED84DD53D> /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen
  Reason: tried: '/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/../lib/libzstd.1.dylib' (no such file), '/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/../lib/libzstd.1.dylib' (no such file)
/bin/sh: line 1: 67900 Abort trap: 6           /Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/NATIVE/bin/llvm-tblgen -gen-intrinsic-enums -I /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR -I/Users/smurdoch/cheri/build/llvm-project-riscv64-hybrid-for-purecap-rootfs-build/include -I/Users/smurdoch/cheri/llvm-project/llvm/include /Users/smurdoch/cheri/llvm-project/llvm/include/llvm/IR/Intrinsics.td --write-if-changed -o include/llvm/IR/IntrinsicEnums.inc -d include/llvm/IR/IntrinsicEnums.inc.d
[247/3634] Building CXX object lib/BinaryFormat/CMakeFiles/LLVMBinaryFormat.dir/MsgPackDocument.cpp.o
ninja: build stopped: subcommand failed.
Fatal error (in target llvm-riscv64-hybrid-for-purecap-rootfs): Command `nice cmake --build . --target all -- -j8` failed with non-zero exit code 134

[jrtc27]

This seems to be an upstream issue with the latest version of macOS: llvm/llvm-project#143515

There's a workaround documented there; with cheribuild you can pass the option via --llvm/cmake-options=-DLLVM_USE_STATIC_ZSTD=TRUE

[sjmurdoch]

Thanks again; I'll take a look but focus on the cross-compilation option.